fix(core): loosen instanceof check

Author: nartc

Diff for: libs/core/src/lib/roots.ts

@@ -10,7 +10,6 @@ import {
 	Raycaster,
 	Scene,
 	VSMShadowMap,
-	Vector3,
 } from 'three';
 import { prepare } from './instance';
 import { injectLoop, roots } from './loop';
@@ -133,7 +132,7 @@ export function injectCanvasRootInitializer(injector?: Injector) {
 							// always look at center or passed-in lookAt by default
 							if (!state.camera && !cameraOptions?.rotation && !cameraOptions?.quaternion) {
 								if (Array.isArray(lookAt)) camera.lookAt(lookAt[0], lookAt[1], lookAt[2]);
-								else if (lookAt instanceof Vector3) camera.lookAt(lookAt);
+								else if (lookAt?.isVector3) camera.lookAt(lookAt);
 								else camera.lookAt(0, 0, 0);
 							}
 
@@ -154,7 +153,7 @@ export function injectCanvasRootInitializer(injector?: Injector) {
 					if (!state.scene) {
 						let scene: Scene;
 
-						if (sceneOptions instanceof Scene) {
+						if (is.scene(sceneOptions)) {
 							scene = sceneOptions;
 						} else {
 							scene = new Scene();

Diff for: libs/core/src/lib/store.ts

@@ -32,8 +32,8 @@ function storeFactory(previousStore: NgtSignalStore<NgtState> | null) {
 			const { width, height, top, left } = size;
 			const aspect = width / height;
 
-			if (target instanceof Vector3) tempTarget.copy(target);
-			else tempTarget.set(...target);
+			if ((target as Vector3).isVector3) tempTarget.copy(target as Vector3);
+			else tempTarget.set(...(target as [number, number, number]));
 
 			const distance = camera.getWorldPosition(position).distanceTo(tempTarget);
 

Diff for: libs/core/src/lib/utils/apply-props.ts

@@ -1,4 +1,4 @@
-import { Color, ColorManagement, Layers, RGBAFormat, Texture, UnsignedByteType } from 'three';
+import { ColorManagement, Layers, RGBAFormat, Texture, UnsignedByteType } from 'three';
 import { getLocalState, invalidateInstance } from '../instance';
 import { NgtAnyRecord, NgtInstanceNode, NgtState } from '../types';
 import { is } from './is';
@@ -63,7 +63,7 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord) {
 
 		// special treatmen for objects with support for set/copy, and layers
 		if (targetProp && targetProp['set'] && (targetProp['copy'] || targetProp instanceof Layers)) {
-			const isColor = targetProp instanceof Color;
+			const isColor = targetProp.isColor;
 			// if value is an array
 			if (Array.isArray(value)) {
 				if (targetProp['fromArray']) targetProp['fromArray'](value);
@@ -79,7 +79,7 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord) {
 				if (!ColorManagement && !rootState.linear && isColor) targetProp['convertSRGBToLinear']();
 			} // if nothing else fits, just set the single value, ignore undefined
 			else if (value !== undefined) {
-				const isColor = targetProp instanceof Color;
+				const isColor = targetProp.isColor;
 				// allow setting array scalars
 				if (!isColor && targetProp['setScalar']) targetProp['setScalar'](value);
 				// layers have no copy function, copy the mask
@@ -95,7 +95,7 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord) {
 			currentInstance[key] = value;
 			// auto-convert srgb textures
 			if (
-				currentInstance[key] instanceof Texture &&
+				currentInstance[key].isTexture &&
 				currentInstance[key].format === RGBAFormat &&
 				currentInstance[key].type === UnsignedByteType
 			) {