Skip to content

Commit f8f93a5

Browse files
committed
fix(soba): fix options type for helper
1 parent 434c3ed commit f8f93a5

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

libs/soba/abstractions/src/lib/helper.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ export function injectHelper<
2626
helperConstructor: () => TConstructor,
2727
{
2828
injector,
29-
args = () => [] as unknown as HelperArgs<TConstructor>,
30-
}: { injector?: Injector; args?: () => HelperArgs<TConstructor> } = {},
29+
args = () => [] as unknown as HelperArgs<ConstructorParameters<TConstructor>>,
30+
}: { injector?: Injector; args?: () => HelperArgs<ConstructorParameters<TConstructor>> } = {},
3131
) {
3232
return assertInjector(injectHelper, injector, () => {
3333
const autoEffect = injectAutoEffect();
@@ -84,7 +84,9 @@ export function injectHelper<
8484
})
8585
export class NgtsHelper<TConstructor extends new (...args: any[]) => Object3D> {
8686
type = input.required<TConstructor>();
87-
options = input<HelperArgs<TConstructor>>([] as unknown as HelperArgs<TConstructor>);
87+
options = input<HelperArgs<ConstructorParameters<TConstructor>>>(
88+
[] as unknown as HelperArgs<ConstructorParameters<TConstructor>>,
89+
);
8890

8991
helperRef = viewChild.required<ElementRef<Object3D>>('helper');
9092

libs/soba/src/abstractions/helper.stories.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ class CameraHelperStory {
4646
<ngt-sphere-geometry />
4747
<ngt-mesh-basic-material />
4848
49-
<ngts-helper [type]="BoxHelper" [options]="$any(['royalblue'])" />
50-
<ngts-helper [type]="VertexNormalsHelper" [options]="$any([1, '#ff0000'])" />
49+
<ngts-helper [type]="BoxHelper" [options]="['royalblue']" />
50+
<ngts-helper [type]="VertexNormalsHelper" [options]="[1, '#ff0000']" />
5151
</ngt-mesh>
5252
`,
5353
schemas: [CUSTOM_ELEMENTS_SCHEMA],

0 commit comments

Comments
 (0)