coffeelint enforcing

Author: nmccready

Gruntfile.coffee

@@ -2,6 +2,9 @@ log = require('util').log
 _ = require 'lodash'
 kickoff = require 'karma-kickoff'
 argv = require('yargs').argv
+coffeelint = require './grunt/coffeelint'
+watch = require './grunt/options/watch'
+
 
 module.exports = (grunt) ->
   # Load the required plugins
@@ -41,23 +44,35 @@ module.exports = (grunt) ->
     allExamplesOpen[root] =
       path: pathValue
 
-#  console.log allExamplesOpen, true
 
   showOpenType = (toIterate = allExamplesOpen) ->
     _(toIterate).each (v, k) ->
       log "#{k} -> #{v.path}"
+
   #showAllExamples()
+
   options.open = _.extend options.open, allExamplesOpen
   grunt.initConfig options
 
+  lints = _.keys(_.omit(watch.coffeelint, 'options'))
+
+  lints.forEach (n) ->
+    grunt.registerTask "coffeelint:#{n}", ->
+      coffeelint({src:watch.coffeelint[n].files, doThrow:false}, @async())
+
+    grunt.registerTask "coffeelint:#{n}:throw", ->
+      coffeelint({src:watch.coffeelint[n].files}, @async())
+
+  grunt.registerTask 'lint', (lints.map (n) -> "coffeelint:#{n}").concat (lints.map (n) -> "watch:coffeelint-#{n}")
+
   grunt.registerTask 'build', ['bower', 'clean:dist', 'jshint', 'mkdir', 'coffee', 'ngAnnotate',
   'concat:libs', 'replace', 'webpack:commonjsDeps']
 
   grunt.registerTask 'buildDist', ['build', 'concat:dist']
 
   grunt.registerTask "default", [ 'verbosity', 'buildDist', 'copy', 'uglify:dist', 'uglify:streetview', 'karma']
 
-  grunt.registerTask "buildAll", [ "build", "concat",
+  grunt.registerTask "buildAll", (lints.map (n) -> "coffeelint:#{n}:throw").concat [ "build", "concat",
     "uglify", "copy", "karma", "graph"]
 
   # run default "grunt" prior to generate _SpecRunner.html

coffeelint.json

@@ -110,5 +110,30 @@
     "non_empty_constructor_needs_parens": {
         "name": "non_empty_constructor_needs_parens",
         "level": "ignore"
-    }
+    },
+    "check_scope": {
+    "module": "coffeescope2",
+    "level": "error",
+    "environments": ["es5", "node", "commonjs", "jasmine", "browser"],
+    "globals": {
+      "_": true,
+      "angular": true,
+      "google": true,
+      "inject": true,
+      "NgMapMarkerClusterer": true,
+      "MarkerWithLabel": true,
+      "RichMarker": true,
+      "PropMap": true
+    },
+    "overwrite": false,
+    "shadow": false,
+    "shadow_builtins": true,
+    "shadow_exceptions": ["err", "next"],
+    "undefined": true,
+    "hoist_local": true,
+    "hoist_parent": true,
+    "unused_variables": true,
+    "unused_arguments": false,
+    "unused_classes": false
+  }
 }

dist/angular-google-maps-street-view_dev_mapped.min.js.map

@@ -2029,7 +2029,6 @@ Nicholas McCready - https://twitter.com/nmccready
           }
           this.opt_options = opt_options != null ? opt_options : {};
           this.opt_events = opt_events;
-          this.checkSync = bind(this.checkSync, this);
           this.getGMarkers = bind(this.getGMarkers, this);
           this.fit = bind(this.fit, this);
           this.destroy = bind(this.destroy, this);
@@ -2347,14 +2346,12 @@ Nicholas McCready - https://twitter.com/nmccready
           this.opt_options = opt_options != null ? opt_options : {};
           this.opt_events = opt_events;
           this.scope = scope;
-          this.checkSync = bind(this.checkSync, this);
           this.isSpiderfied = bind(this.isSpiderfied, this);
           this.getGMarkers = bind(this.getGMarkers, this);
           this.fit = bind(this.fit, this);
           this.destroy = bind(this.destroy, this);
           this.attachEvents = bind(this.attachEvents, this);
           this.clear = bind(this.clear, this);
-          this.draw = bind(this.draw, this);
           this.removeMany = bind(this.removeMany, this);
           this.remove = bind(this.remove, this);
           this.addMany = bind(this.addMany, this);
@@ -6385,8 +6382,6 @@ Original idea from: http://stackoverflow.com/questions/22758950/google-map-drawi
 ;(function() {
   angular.module("uiGmapgoogle-maps.directives.api").service("uiGmapICircle", [
     function() {
-      var DEFAULTS;
-      DEFAULTS = {};
       return {
         restrict: "EA",
         replace: true,
@@ -6448,7 +6443,7 @@ Original idea from: http://stackoverflow.com/questions/22758950/google-map-drawi
         }
 
         IControl.prototype.link = function(scope, element, attrs, ctrl) {
-          throw new Exception("Not implemented!!");
+          throw new Error("Not implemented!!");
         };
 
         return IControl;
@@ -6629,8 +6624,6 @@ Original idea from: http://stackoverflow.com/questions/22758950/google-map-drawi
   angular.module('uiGmapgoogle-maps.directives.api').service('uiGmapIRectangle', [
     function() {
       'use strict';
-      var DEFAULTS;
-      DEFAULTS = {};
       return {
         restrict: 'EMA',
         require: '^' + 'uiGmapGoogleMap',

dist/angular-google-maps.js

@@ -3,13 +3,25 @@ _pkg = require './pkg'
 requireDirectory = require 'require-directory'
 allOptions = requireDirectory module, './options/'
 
+#BEGIN append ./node_modules to our path for this process
+#shamelessly copied from gulp-shell
+#https://github.com/sun-zheng-an/gulp-shell/blob/825a24c214ce91027d535ca767df2cfe8745f1a3/index.js#L33-L36
+path = require 'path'
+pathToBin = path.join(process.cwd(), 'node_modules', '.bin')
+pathName = if /^win/.test(process.platform) then 'Path' else 'PATH'
+newPath = pathToBin + path.delimiter + process.env[pathName]
+_.extend(process.env, _.fromPairs([[pathName, newPath]]))
+#END adding node_modules to path
+
 module.exports = (grunt) ->
   options =
     pkg: _pkg
     pkgFn: ->
       grunt.file.readJSON("package.json") #always get latest!
 
+  # coffeelint: disable=check_scope
   for key, val of allOptions
+  # coffeelint: enable=check_scope
     _.extend options, val
 
   options

dist/angular-google-maps.min.js

@@ -1,5 +1,24 @@
-module.exports =
-  watch:
+_ =  require 'lodash'
+
+coffeelint = {}
+for n in ['grunt', 'src', 'spec']
+  coffeelint[n] =
+    options: livereload: true
+    files: [
+      "#{n}/**/*.coffee"
+    ]
+    tasks: ["coffeelint:#{n}"]
+
+
+coffeelint.grunt.files.push '*.coffee'
+
+coffeelintWatches = _.mapKeys coffeelint, (v, k) ->
+  "coffeelint-#{k}"
+
+
+module.exports = {
+  coffeelint
+  watch: _.extend coffeelintWatches,
     offline:
       options:
         livereload: true
@@ -28,3 +47,6 @@ module.exports =
 
       files: ["src/coffee/**/*.coffee"]
       tasks: ["karma"]
+}
+
+# console.log(module.exports)

grunt/options.coffee

@@ -29,12 +29,15 @@
   "license": "MIT",
   "devDependencies": {
     "bower": "~1.4.1",
+    "coffeelint": "1.16.0",
+    "coffeescope2": "0.4.4",
     "data-structures": "^1.4.2",
     "eslint": "3.7.1",
     "eslint-config-airbnb": "12.0.0",
     "eslint-plugin-import": "1.16.0",
     "eslint-plugin-jsx-a11y": "2.2.2",
     "eslint-plugin-react": "6.3.0",
+    "globby": "6.1.0",
     "grunt": "~0.4.5",
     "grunt-angular-architecture-graph": "^0.2.6",
     "grunt-bump": "0.3.1",
@@ -74,6 +77,7 @@
     "mocha": "2.X",
     "phantomjs-polyfill": "0.0.1",
     "require-directory": "2.1.1",
+    "through2": "2.0.3",
     "webpack": "1.X",
     "webpack-dev-server": "1.X",
     "yargs": "3.32.0"

grunt/options/watch.coffee

@@ -1,7 +1,9 @@
 ###global _:true, angular:true, google:true ###
 do ->
+  #coffeelint:disable=check_scope
   capitalize = (s) ->
     return s[0].toUpperCase() + s.slice(1)
+  #coffeelint:enable=check_scope
 
   class MapObject
     getMap: =>
@@ -65,7 +67,9 @@ do ->
     class Marker extends MapObject
       _.extend @::, PositionObject::, DraggableObject::, VisibleObject::
       @instances = 0
+      #coffeelint:disable=no_private_function_fat_arrows
       @resetInstances = =>
+      #coffeelint:enable=no_private_function_fat_arrows
         @instances = 0
       @creationSubscribe = (obj, cb) ->
         window.google.maps.event.addListener(obj, 'creation', cb)
@@ -115,7 +119,9 @@ do ->
     class Circle extends MapObject
       _.extend @::, DraggableObject::, VisibleObject::
       @instances = 0
+      #coffeelint:disable=no_private_function_fat_arrows
       @resetInstances = =>
+      #coffeelint:enable=no_private_function_fat_arrows
         @instances = 0
       @creationSubscribe = (obj, cb) ->
         window.google.maps.event.addListener(obj, 'creation', cb)
@@ -128,16 +134,18 @@ do ->
         @setOptions opts
 
         #getters
+        #coffeelint:disable=check_scope
         @props.forEach (p) =>
-          @["get#{capitalize p}"] = =>
+          @["get#{capitalize(p)}"] = =>
             @[p]
 
         #setters
         @props.forEach (p) =>
-          @["set#{capitalize p}"] = (val) =>
+          @["set#{capitalize(p)}"] = (val) =>
             @[p] = val
             if p == "radius" or p == "center"
               window.google.maps.event.fireAllListeners "#{p}_changed", @
+        #coffeelint:enable=check_scope
 
         Circle.instances += 1
         @instance = Circle.instances
@@ -188,7 +196,9 @@ do ->
   getMarkerWithLabel: ->
     class MarkerWithLabel extends getMarker()
       @instances = 0
+      #coffeelint:disable=no_private_function_fat_arrows
       @resetInstances = =>
+        #coffeelint:enable=no_private_function_fat_arrows
         @instances = 0
       constructor: (opts) ->
         if opts?
@@ -221,8 +231,10 @@ do ->
   getPolyline = ->
     class Polyline extends DraggableObject
       @instances = 0
+      #coffeelint:disable=no_private_function_fat_arrows
       @resetInstances = =>
         @instances = 0
+      #coffeelint:enable=no_private_function_fat_arrows
       constructor: (opts) ->
         if opts?
           ['draggable', 'editable', 'map','path', 'visible'].forEach (o) =>
@@ -241,7 +253,9 @@ do ->
   getMVCArray = ->
     class MVCArray extends Array
       @instances = 0
+      #coffeelint:disable=no_private_function_fat_arrows
       @resetInstances = =>
+      #coffeelint:enable=no_private_function_fat_arrows
         @instances = 0
       constructor: ->
         MVCArray.instances += 1
@@ -480,7 +494,7 @@ do ->
     getLatLng: getLatLng
 
   (new GoogleApiMock()).initAll()
-  
+
   angular.module('uiGmapgoogle-maps.mocks', ['uiGmapgoogle-maps'])
   .factory('GoogleApiMock', ->
     GoogleApiMock

package.json

@@ -1,5 +1,5 @@
 do ->
-  module = angular.module("angular-google-maps-specs", ['uiGmapgoogle-maps'])
+  angular.module("angular-google-maps-specs", ['uiGmapgoogle-maps'])
     .controller 'GoogleMapSpecController', ($scope, $timeout, $log) ->
       self = @
       @hasRun = false

spec/coffee/bootstrap/google-api-mock.coffee

@@ -1,12 +1,16 @@
 describe 'uiGmapCircle', ->
+  #coffeelint:disable=check_scope
   allDone =  undefined
   GCircle = null
   modelClicked = false
+  #coffeelint:enable=check_scope
 
   afterEach ->
     window.google.maps.event.clearListeners()
     GCircle.resetInstances()
+    #coffeelint:disable=check_scope
     modelClicked = false
+    #coffeelint:enable=check_scope
 
   beforeEach ->
 
@@ -49,7 +53,7 @@ describe 'uiGmapCircle', ->
       events: circleEvents
       control: {}
 
-    apiMock = window.uiGmapInitiator
+    window.uiGmapInitiator
     .initMock(@, ->
       GCircle = window.google.maps.Circle
     ).apiMock
@@ -124,7 +128,7 @@ describe 'uiGmapCircle', ->
         @digest =>
           @timeout =>
             @digest =>
-              listener = GCircle.creationSubscribe @, (gObject) =>
+              GCircle.creationSubscribe @, (gObject) =>
                 _.delay =>
                   gObject.setCenter
                     lat: ->

spec/coffee/bootstrap/google-map-spec-controller.coffee

@@ -15,7 +15,7 @@ describe "directives.api.control", ->
         <ui-gmap-map-control template="mockControl.tpl.html"></ui-gmap-map-control>
       </ui-gmap-google-map>
       """
-    element = @compile(html)(@scope)
+    @compile(html)(@scope)
     @rootScope.$apply()
     expect(@log.error).not.toHaveBeenCalled()
     @log.error.calls.reset()
@@ -27,7 +27,7 @@ describe "directives.api.control", ->
             <ui-gmap-map-control template="mockControl.tpl.html" position="bad-position">
             </ui-gmap-map-control>
         </ui-gmap-google-map>"""
-    element = @compile(html)(@scope)
+    @compile(html)(@scope)
     @rootScope.$apply()
     expect(@log.error).toHaveBeenCalledWith('mapControl: invalid position property')
     @log.error.calls.reset()
@@ -38,7 +38,7 @@ describe "directives.api.control", ->
         <ui-gmap-map-control template="mockControl.tpl.html" position="bottom-center"></ui-gmap-map-control>
       </ui-gmap-google-map>
       """
-    element = @compile(html)(@scope)
+    @compile(html)(@scope)
     @rootScope.$apply()
     expect(@log.error).not.toHaveBeenCalled()
     @log.error.calls.reset()
@@ -49,7 +49,7 @@ describe "directives.api.control", ->
         <ui-gmap-map-control template="mockControl.tpl.html" position="ToP_LefT"></ui-gmap-map-control>
       </ui-gmap-google-map>
       """
-    element = @compile(html)(@scope)
+    @compile(html)(@scope)
     @rootScope.$apply()
     expect(@log.error).not.toHaveBeenCalled()
     @log.error.calls.reset()

spec/coffee/directives/api/circle.spec.coffee

@@ -1,5 +1,4 @@
 describe 'uiGmapDragZoom spec', ->
-  allDone = undefined
 
   beforeEach ->
 
@@ -30,7 +29,7 @@ describe 'uiGmapDragZoom spec', ->
 
     spyOn(scope.spec, 'enableKeyDragZoom')
 
-    element = @compile(html)(scope)
+    @compile(html)(scope)
 
     @digest () =>
       @timeout () ->