fix(tooltip): close tooltips appended to body on location change

Closes #345
angular-ui · May 4, 2013 · 041261b · 041261b
1 parent 76fee1f
commit 041261b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/src/tooltip/test/tooltip.spec.js b/src/tooltip/test/tooltip.spec.js
@@ -309,6 +309,26 @@ describe( '$tooltipProvider', function() {
       expect( elmBody.children().length ).toBe( 1 );
       expect( $body.children().length ).toEqual( bodyLength + 1 );
     }));
+
+    it('should close on location change', inject( function( $rootScope, $compile) {
+
+      elmBody = angular.element(
+        '<div><span tooltip="tooltip text">Selector Text</span></div>'
+      );
+
+      scope = $rootScope;
+      $compile(elmBody)(scope);
+      scope.$digest();
+      elm = elmBody.find('span');
+      elmScope = elm.scope();
+
+      elm.trigger( 'mouseenter' );
+      expect( elmScope.tt_isOpen ).toBe( true );
+
+      scope.$broadcast('$locationChangeSuccess');
+      scope.$digest();
+      expect( elmScope.tt_isOpen ).toBe( false );
+    }));
   });
 
   describe( 'triggers', function() {

diff --git a/src/tooltip/tooltip.js b/src/tooltip/tooltip.js
@@ -266,6 +266,11 @@ angular.module( 'ui.bootstrap.tooltip', [ 'ui.bootstrap.position' ] )
               element.bind( triggers.hide, hideTooltipBind );
             }
           });
+
+          //if a tooltip is attached to <body> we need to remove it on location change
+          if ( options.appendToBody ) {
+            scope.$on('$locationChangeSuccess', hide);
+          }
         }
       };
     };
@@ -296,7 +301,4 @@ angular.module( 'ui.bootstrap.tooltip', [ 'ui.bootstrap.position' ] )
 
 .directive( 'tooltipHtmlUnsafe', [ '$tooltip', function ( $tooltip ) {
   return $tooltip( 'tooltipHtmlUnsafe', 'tooltip', 'mouseenter' );
-}])
-
-;
-
+}]);