Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
fix(modal): controllerAs not checked
Browse files Browse the repository at this point in the history
This causes the controller to be added to the scope as a property "undefined"!

Closes #2564
  • Loading branch information
aeharding authored and pkozlowski-opensource committed Aug 15, 2014
1 parent a0be450 commit 7b7cdf8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/modal/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
});

ctrlInstance = $controller(modalOptions.controller, ctrlLocals);
if (modalOptions.controller) {
if (modalOptions.controllerAs) {
modalScope[modalOptions.controllerAs] = ctrlInstance;
}
}
Expand Down

0 comments on commit 7b7cdf8

Please sign in to comment.