feat(alert): add WAI-ARIA markup

Closes #1806
angular-ui · Feb 15, 2014 · 9a2638b · 9a2638b
1 parent bce2505
commit 9a2638b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/alert/test/alert.spec.js b/src/alert/test/alert.spec.js
@@ -1,5 +1,4 @@
 describe('alert', function () {
-
   var scope, $compile;
   var element;
 
@@ -36,7 +35,7 @@ describe('alert', function () {
   }
 
   function findContent(index) {
-    return element.find('span').eq(index);
+    return element.find('div[ng-transclude] span').eq(index);
   }
 
   it('should generate alerts using ng-repeat', function () {

diff --git a/template/alert/alert.html b/template/alert/alert.html
@@ -1,4 +1,7 @@
-<div class="alert" ng-class="{'alert-{{type || 'warning'}}': true, 'alert-dismissable': closeable}">
-    <button ng-show="closeable" type="button" class="close" ng-click="close()">&times;</button>
+<div class="alert" ng-class="{'alert-{{type || 'warning'}}': true, 'alert-dismissable': closeable}" role="alert">
+    <button ng-show="closeable" type="button" class="close" ng-click="close()">
+        <span aria-hidden="true">&times;</span>
+        <span class="sr-only">Close</span>
+    </button>
     <div ng-transclude></div>
 </div>