fix(rating): re-expose RatingController

- Re-expose `RatingController` with deprecation notice Closes #4529
angular-ui · Oct 3, 2015 · aede646 · aede646
1 parent 5604e59
commit aede646
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/rating/rating.js b/src/rating/rating.js
@@ -104,6 +104,17 @@ angular.module('ui.bootstrap.rating')
 
 .value('$ratingSuppressWarning', false)
 
+.controller('RatingController', ['$scope', '$attrs', '$controller', '$log', '$ratingSuppressWarning', function($scope, $attrs, $controller, $log, $ratingSuppressWarning) {
+  if (!$ratingSuppressWarning) {
+    $log.warn('RatingController is now deprecated. Use UibRatingController instead.');
+  }
+
+  angular.extend(this, $controller('UibRatingController', {
+    $scope: $scope,
+    $attrs: $attrs
+  }));
+}])
+
 .directive('rating', ['$log', '$ratingSuppressWarning', function($log, $ratingSuppressWarning) {
   return {
     require: ['rating', 'ngModel'],
@@ -112,7 +123,7 @@ angular.module('ui.bootstrap.rating')
       onHover: '&',
       onLeave: '&'
     },
-    controller: 'UibRatingController',
+    controller: 'RatingController',
     templateUrl: 'template/rating/rating.html',
     replace: true,
     link: function(scope, element, attrs, ctrls) {

diff --git a/src/rating/test/rating.spec.js b/src/rating/test/rating.spec.js
@@ -354,7 +354,8 @@ describe('rating deprecation', function() {
     var element = $compile('<rating ng-model="rate"></rating>')($rootScope);
     $rootScope.$digest();
 
-    expect($log.warn.calls.count()).toBe(1);
-    expect($log.warn.calls.argsFor(0)).toEqual(['rating is now deprecated. Use uib-rating instead.']);
+    expect($log.warn.calls.count()).toBe(2);
+    expect($log.warn.calls.argsFor(0)).toEqual(['RatingController is now deprecated. Use UibRatingController instead.']);
+    expect($log.warn.calls.argsFor(1)).toEqual(['rating is now deprecated. Use uib-rating instead.']);
   }));
 });