Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Memory leak using tooltip and ngRepeat #1400

Closed
landrade opened this issue Dec 13, 2013 · 8 comments
Closed

Memory leak using tooltip and ngRepeat #1400

landrade opened this issue Dec 13, 2013 · 8 comments

Comments

@landrade
Copy link

When i use the tooltip with ngRepeat and change de provider, for some reason the GC doesn't clean the nodes created by template of tooltip, causing memory leak.

this code simulates the problem: http://codepen.io/anon/pen/KCklA

Developer tool's with tooltip http://imgur.com/mwnIGUs

Developer tool's without tooltip http://imgur.com/zqKav5x

@pkozlowski-opensource
Copy link
Member

@landrade you are using quite old version of the library (0.5.0). The current version is 0.7.0 and it has some fixes for tooltip DOM node leaks. Could you please re-test with 0.7.0 and let me know if it fixes things for you?

@landrade
Copy link
Author

@pkozlowski-opensource i did the migration to 0.7.0 version and it continues leaking.
Below is a link to my tests:
http://codepen.io/landrade/pen/fnrwv

(at this state the application crashed)
screen shot 2013-12-13 at 1 16 09 pm

@bekos bekos closed this as completed in 3fe7aa8 Dec 14, 2013
@bekos
Copy link
Contributor

bekos commented Dec 14, 2013

@landrade A fix has landed in master. Please verify that this problem is actually solved via 3fe7aa8 by using http://ci.angularjs.org/job/angularui-bootstrap/ws/dist/ui-bootstrap-tpls-0.8.0-SNAPSHOT.js script.

@luksch
Copy link

luksch commented Dec 16, 2013

I don't see that the issue is fixed. landrade's test seems to include the lates fixed version http://ci.angularjs.org/job/angularui-bootstrap/ws/dist/ui-bootstrap-tpls-0.8.0-SNAPSHOT.js
and still crashes in no time...

see
http://codepen.io/landrade/pen/fnrwv

@bekos
Copy link
Contributor

bekos commented Dec 16, 2013

That example has unnecessary stuff like bootstrap's js and jquery. Look here: http://codepen.io/anon/pen/HGvFD

@luksch
Copy link

luksch commented Dec 16, 2013

okay, then i need to extract from my own code an example, because i do face this issue even after the fix. So my problem also might be related to jQuery and stuff. maybe you can hint, why the cluttered example is not fixed by http://ci.angularjs.org/job/angularui-bootstrap/ws/dist/ui-bootstrap-tpls-0.8.0-SNAPSHOT.js

@bekos
Copy link
Contributor

bekos commented Dec 16, 2013

There seems to be a problem when jQuery is present! I really can't tell atm what maybe causing it.I will try to have another look when I find time, but I wouldn't be surprised if it is a jQuery bug.

@luksch
Copy link

luksch commented Dec 16, 2013

thx for pointing that out. You might be right at this. damn! i need jquery and tooltips...

I just tried your example with loading the latest jquery before angular and that results in the memory leak. so at least we know for sure it is connected to jquery.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants