Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

PR for multi-line typeahead, failing to test #1687

Closed
dmatteo opened this issue Jan 28, 2014 · 2 comments
Closed

PR for multi-line typeahead, failing to test #1687

dmatteo opened this issue Jan 28, 2014 · 2 comments

Comments

@dmatteo
Copy link
Contributor

dmatteo commented Jan 28, 2014

Hey guys,

following a similar PR occured in ngRepeat, I've expanded the typeahead REGEXP to allow multiple line expressions, like:

   typeahead="datum as ( datum.name + datum.description ) for datum in data
                | filter:{name: $viewValue}
                | orderBy: reverse"

In my use case, everything worked fine, and even running the "old" test with grunt watch gave positive results.

However, due to my ng-newbiness, I was unable to write a working "IT clause" for testing the newline.

Here you can see one of the most plausible test attempt, that still doesn't work dmatteo/bootstrap@2b31de9fa7e07f4496dcc7a515db108db86c5e77

Can someone point me in the right direction?

@chrisirhc
Copy link
Contributor

Dropped you a comment on that commit. There was an error in the JavaScript string.

@dmatteo
Copy link
Contributor Author

dmatteo commented Feb 24, 2014

Thank you very much.

I was able to write a (new) test case, also thanks to your suggestion.

I'll submit a PR really soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants