This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): remove C restrictions to avoid conflicts
#2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes angular-ui#2156 BREAKING CHANGES: Both `dropdown` and `dropdown-toggle` are only attribute directives Before: ```html <btutton class="dropdown-toggle" ...> ``` After: ```html <btutton class="dropdown-toggle" dropdown-toggle ...> ```
|
It would be great if this could get merged! I'm currently working on a project where I've had to implement the same fix to avoid a naming collision. Quite a few of these directives have generic, non-namespaced names that have caused problems for me. |
jurassic-c
pushed a commit
to jurassic-c/bootstrap
that referenced
this pull request
Aug 6, 2014
Fixes angular-ui#2156 BREAKING CHANGES: Both `dropdown` and `dropdown-toggle` are only attribute directives Before: ```html <btutton class="dropdown-toggle" ...> ``` After: ```html <btutton class="dropdown-toggle" dropdown-toggle ...> ``` Closes angular-ui#2170
ulle
pushed a commit
to ulle/bootstrap
that referenced
this pull request
Oct 22, 2014
Fixes angular-ui#2156 Closes angular-ui#2170 BREAKING CHANGE: Both `dropdown` and `dropdown-toggle` are only attribute directives Before: ```html <button class="dropdown-toggle" ...> ``` After: ```html <button class="dropdown-toggle" dropdown-toggle ...> ```
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Fixes angular-ui#2156 BREAKING CHANGES: Both `dropdown` and `dropdown-toggle` are only attribute directives Before: ```html <btutton class="dropdown-toggle" ...> ``` After: ```html <btutton class="dropdown-toggle" dropdown-toggle ...> ``` Closes angular-ui#2170
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Fixes angular-ui#2156 Closes angular-ui#2170 BREAKING CHANGE: Both `dropdown` and `dropdown-toggle` are only attribute directives Before: ```html <button class="dropdown-toggle" ...> ``` After: ```html <button class="dropdown-toggle" dropdown-toggle ...> ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.