Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

PaginationController init not called before $watch triggered #2227

Closed
pschuegr opened this issue May 20, 2014 · 4 comments
Closed

PaginationController init not called before $watch triggered #2227

pschuegr opened this issue May 20, 2014 · 4 comments

Comments

@pschuegr
Copy link
Contributor

Hi there,

I'm having a minor issue with the PaginationController. If the $watch on 'totalPages' is triggered before init is called, the ngModelCtrl.$render does not exist:

https://github.com/angular-ui/bootstrap/blob/master/src/pagination/pagination.js#L8

Maybe the watch should be set up in the init?

@bekos
Copy link
Contributor

bekos commented May 20, 2014

@pschuegr Thx for reporting. This seems like a duplicate of #2108 and I was also thinking of initializing the watch inside the init, as a probable solution. What about sending a PR for this?

@pschuegr
Copy link
Contributor Author

@bekos. NP - I'm travelling and offline a lot in the next few days but will try and get to it!

@hindsholm
Copy link

I am also facing this issue, and I can verify that the fix created by @pschuegr does indeed solve the problem. Please accept the pull request!

@nitso
Copy link

nitso commented Nov 7, 2014

The same issue here. So old pull request!

@chrisirhc chrisirhc added this to the Purgatory milestone Nov 17, 2014
@chrisirhc chrisirhc modified the milestones: Backlog, Purgatory Nov 17, 2014
@wesleycho wesleycho modified the milestones: 0.13.0, Backlog Apr 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants