Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

typeahead closing modal #243

Closed
amfern opened this issue Mar 19, 2013 · 4 comments
Closed

typeahead closing modal #243

amfern opened this issue Mar 19, 2013 · 4 comments

Comments

@amfern
Copy link

amfern commented Mar 19, 2013

pressing Esc key will close typeahead as it should but if its nested inside of modal, the modal will close as well.

i am suggesting stoping event propagation if typeahead is open pressing Esc will

@jhiemer
Copy link

jhiemer commented Mar 19, 2013

+1

@amfern
Copy link
Author

amfern commented Mar 21, 2013

it should stop propagate only if there matches hence dropmenu is open. if no matches it should propagate the event to modal.

@pkozlowski-opensource
Copy link
Member

@amfern sure, this is what I believe I did in 22a00cd

Did you try it out and it didn't work for you?

@amfern
Copy link
Author

amfern commented Mar 21, 2013

@pkozlowski-opensource my bad works like a charm, thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants