Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add Travis build against 1.3.0-beta.N #2440

Closed
wants to merge 2 commits into from
Closed

Add Travis build against 1.3.0-beta.N #2440

wants to merge 2 commits into from

Conversation

myitcv
Copy link

@myitcv myitcv commented Jul 10, 2014

Approaching the Angular 1.3.0 release it would seem sensible to expose angular-ui to tests against 1.3.0-beta.N

I'm not sure whether my approach to finding the latest 1.3.0-beta.N is ideal but couldn't find a better way of constraining it whilst still avoiding the various build tags.

Rationale

The typeahead component has been broken since Angular 1.3.0-beta.11 but we have no visibility on this in angular-ui

Thoughts?

@myitcv
Copy link
Author

myitcv commented Jul 10, 2014

Just to note the Travis build is showing (at the time of writing) as having passed vs. Angular v1.2.19 but failed vs. Angular v1.3.0-beta.14 - those failures relate to typeahead, as discussed in #2293

@pkozlowski-opensource
Copy link
Member

@myitcv this is good idea to use Travis matrix to test with multiple versions of AngularJS. Still I'm not sure if it is worth it to use Bower here - maybe we simply should have 2 Karma configs with AngularJS pulled from a CDN?

@myitcv
Copy link
Author

myitcv commented Jul 10, 2014

@pkozlowski-opensource - very much defer to others with more experience here on the best way of achieving this!

The requirements of any solution from my perspective are:

  • test against the latest v1.2.x
  • test against the latest v1.3.0-beta.x
  • no manual intervention required to test a new release (i.e. we don't want to have to tweak a Karma config every time there is a release of either v1.2.x or v1.3.0-beta.x)
  • pull these files from a trusted location

For now my rather hacky bower | grep | head approach works. Albeit maybe not the most efficient mechanism, we now have visibility on the failing tests against v1.3.0-beta.x

@myitcv
Copy link
Author

myitcv commented Jul 15, 2014

@pkozlowski-opensource - any thoughts on getting this merged?

@chrisirhc
Copy link
Contributor

We'll need to work on 1.3 compatibility when it's more stable. It wouldn't make sense to merge this before that.

@antoinepairet
Copy link

This commit updated the angular version to 1.3.13.
5f9afe5

Closing for now

regards

@karianna karianna added this to the 0.13.0 milestone Feb 21, 2015
antoinepairet pushed a commit that referenced this pull request Feb 21, 2015
@DaveWM
fix(datepicker): date formatting when using angular 1.3 fixes #2659
23936f9 
Closes #3293
Closes #3279
Closes #2440
Closes #2932
Closes #3074
Closes #2943
Closes #2733

Fixes #3047
Fixes #2659
Fixes #2681
DKnodel pushed a commit to DKnodel/bootstrap that referenced this pull request Apr 9, 2015
@DaveWM
fix(datepicker): date formatting when using angular 1.3 fixes angular…
03e9586 
…-ui#2659

Closes angular-ui#3293
Closes angular-ui#3279
Closes angular-ui#2440
Closes angular-ui#2932
Closes angular-ui#3074
Closes angular-ui#2943
Closes angular-ui#2733

Fixes angular-ui#3047
Fixes angular-ui#2659
Fixes angular-ui#2681
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
AngularJS 1.3
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

Successfully merging this pull request may close these issues.
5 participants
@myitcv @pkozlowski-opensource @chrisirhc @antoinepairet @karianna