Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

appendTo option for modal dialog #2688

Closed
mhaertwig opened this issue Sep 11, 2014 · 5 comments
Closed

appendTo option for modal dialog #2688

mhaertwig opened this issue Sep 11, 2014 · 5 comments
Labels
component: modal type: enhancement
Milestone
1.0.0

Comments

@mhaertwig
Copy link

What about a "appendTo" option for the modal dialog?

In my application I would like to use the modal dialog in an element that can be set to fullscreen mode. However, since the modal dialog is appended to the body by default, the dialog disappears every time application's main container is set to fullscreen. Therefore an option to configure the modal dialog's parent element (e.g. "appendTo") would be nice.
@seinavco
Copy link

+1

@chrisirhc chrisirhc added this to the Backlog milestone Nov 2, 2014
@chrisirhc
Copy link
Contributor

This also aids accessibility, PRs are welcome.

@chrisirhc chrisirhc mentioned this issue Nov 3, 2014
Closed
@Lalem001 Lalem001 mentioned this issue Nov 7, 2014
Closed
@wesleycho wesleycho modified the milestones: 0.13.1, Backlog Apr 5, 2015
@Lalem001 Lalem001 mentioned this issue Apr 8, 2015
Closed
@rvanbaalen rvanbaalen mentioned this issue Apr 10, 2015
Closed
@YidingW
Copy link

YidingW commented Jun 2, 2015

+1

@wesleycho wesleycho modified the milestones: 0.13.1 (npm), 0.13.2 (Performance) Jul 23, 2015
@wesleycho wesleycho modified the milestones: 0.13.2 (1.4 support), 0.13.3 (Performance), Backlog, 0.13.3 (Fixes) Aug 2, 2015
@aroop aroop mentioned this issue Oct 26, 2015
Closed
@icfantv
Copy link
Contributor

icfantv commented Oct 29, 2015

Linking in #4772 but leaving this open for now.

@wesleycho
Copy link
Contributor

This has landed as 16d854c in master.

@wesleycho wesleycho modified the milestones: 1.0.0, Backlog Oct 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: modal type: enhancement
Projects
None yet
Milestone
1.0.0
7 participants
@chrisirhc @rvanbaalen @icfantv @wesleycho @mhaertwig @YidingW @seinavco