This repository has been archived by the owner on May 29, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example of a fragment URI that exists in the documentation:
http://angular-ui.github.io/bootstrap/#datepicker
Within the documentation page, this gets picked up by smoothscroll-angular-custom.js and converted to this:
http://angular-ui.github.io/bootstrap/#/datepicker
Unfortunately, when you try to navigate fresh to either of those urls, the initialize code in app.js picks up the hash location and doesn't properly replace the element id, resulting in the following 404 page:
The
location.replace()
method should include the anchor tag and the element ID as can be seen in smoothscroll-angular-custom.jsThis will produce the proper result when navigating from elsewhere on the web and fix a lot of broken links.
Both of the following on my forked version of
gh-pages
should work:http://kylemitofsky.com/angular-bootstrap/#datepicker
http://kylemitofsky.com/angular-bootstrap/#/datepicker