Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Modal result promise is resolved prior to animations completing when closing the modal #3057

Closed
nauticalcoder opened this issue Dec 6, 2014 · 3 comments

Comments

@nauticalcoder
Copy link

Angular version: 1.2.16
Angular Bootstrap version: 0.12.0
Bootstrap version: 3.1.1
http://plnkr.co/edit/xNCeqlj9cXKjTtQOSoiN

I am trying to have a message box display after the modal is closed. The code for opening the message box is in the result promise handler. When close is called on the modal instance, the message box is displaying, then once the message box is closed, the modal is closing. After investigating, the issue appears to be related to the close animation. I have included a proposed fix for this issue that involves moving the promise resolution so it happens once the animation is complete.
Pull request a proposed solution:
#3056

@chrisirhc
Copy link
Contributor

Should investigate this only after #2724 is merged.

@chrisirhc chrisirhc added this to the Purgatory milestone Mar 19, 2015
@wesleycho wesleycho modified the milestones: 0.13.x, Purgatory Aug 17, 2015
@wesleycho wesleycho self-assigned this Aug 17, 2015
@wesleycho
Copy link
Contributor

I will take a look at implementing this sometime in the next couple of weeks - this requires branching out the logic depending on a configuration value.

@wesleycho
Copy link
Contributor

Closing as resolved via e9c4977

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants