You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
I've set the first day of my datepickers to 1, meaning the weeks start on monday.
I'm encountering a strange bug now though. December of this year (2014) shows a full week of January (5-1 / 11-1). The datepicker also says this is week 54. The week before that is week 53 according to the datepicker. These weeks should be week 1 and 2.
Even stranger behaviour is when I check out December 2015 and January 2016.
The numbering of weeks is wrong. The numbering is correct again in February 2016. I haven't checked out more years, but I'm guessing thesame problem arises...
The text was updated successfully, but these errors were encountered:
An additional problem with this is that even the week numbers in December are wrong. 2014's week 52 was the week that started with December 22 (or December 21 if you start on Sundays). The week numbers are off by +1.
All this was already covered in #2506, it seems a fix for that issue was already committed but the guy never updated his code after review feedback was provided. I will look into this tomorrow and update the pull request.
A fix for the starting day that PR references had already been made in the meantime, I added fixes for the January week numbers and adjusted the algorithm to remove the wrong offset in all week numbers. New PR here: #3158
I've set the first day of my datepickers to 1, meaning the weeks start on monday.
I'm encountering a strange bug now though. December of this year (2014) shows a full week of January (5-1 / 11-1). The datepicker also says this is week 54. The week before that is week 53 according to the datepicker. These weeks should be week 1 and 2.
Even stranger behaviour is when I check out December 2015 and January 2016.
The numbering of weeks is wrong. The numbering is correct again in February 2016. I haven't checked out more years, but I'm guessing thesame problem arises...
The text was updated successfully, but these errors were encountered: