Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(timepicker): remove ng-mousewheel binding #3442

Merged
merged 1 commit into from
Mar 25, 2015
Merged

fix(timepicker): remove ng-mousewheel binding #3442

merged 1 commit into from
Mar 25, 2015

Conversation

RobJacobs
Copy link
Contributor

The timepicker template has an ng-mousewheel
binding on the hours input element and the
TimepickerController also binds the elemeent
to mouse wheel events. Removed ng-mousewheel
binding from the template.

@RobJacobs
fix(timepicker): remove ng-mousewheel binding
a726b7c 
The timepicker template has an ng-mousewheel
binding on the hours input element and the
TimepickerController also binds the elemeent
to mouse wheel events.  Removed ng-mousewheel
binding from the template.

Closes #3442
@chrisirhc
Copy link
Contributor

Small thing, could you change the commit message to be of refactor type since this isn't meant to change any behavior? Actually, it probably should be a fix. Weird that the mousewheel events in the tests didn't break.

Otherwise, LGTM 👍

@RobJacobs RobJacobs merged commit a726b7c into angular-ui:master Mar 25, 2015
@RobJacobs RobJacobs deleted the fix/timepicker branch March 25, 2015 19:42
@karianna karianna added this to the 0.13.0 milestone Mar 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: timepicker type: bug
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

Successfully merging this pull request may close these issues.
3 participants
@RobJacobs @chrisirhc @karianna