fix(carousel): disable transition until animation completes #3757
Conversation
| @@ -1,6 +1,6 @@ | |||
| <div ng-mouseenter="pause()" ng-mouseleave="play()" class="carousel" ng-swipe-right="prev()" ng-swipe-left="next()"> | |||
| <ol class="carousel-indicators" ng-show="slides.length > 1"> | |||
| <li ng-repeat="slide in slides | orderBy:'index' track by $index" ng-class="{active: isActive(slide)}" ng-click="select(slide)"></li> | |||
| <li ng-repeat="slide in slides | orderBy:'index' track by $index" ng-class="{active: isActive(slide)}" ng-click="!$currentTransition && select(slide)"></li> | |||
There was a problem hiding this comment.
Shouldn't this !$currentTransition be done inside the select() instead of explicitly having to set it within the ng-click?
There was a problem hiding this comment.
I'm willing to make that change, but it should be noted that both the next and prev methods check that property as well, and if it is falsey, then select is called. Theoretically, I would prefer to have it be inside the function instead of being parsed by Angular, but then it requires thought about those methods. I could move the check into select instead and delete those lines from the next and prev functions.
There was a problem hiding this comment.
I would go for that indeed. Just keep the currentTransition variable as an internal flag like suggested also keeps the template cleaner.
We promote overwriting templates to implement custom designs/functionality. By keeping $currentTransition out of the template, there is one less variable to keep in mind that could potentially break a custom template.
- Force the carousel indicator to not select the slide if the animation has not completed - Factor out `goNext` function to not redefine on each execution of `select` chore(carousel): move `$currentTransition` check to `select` method
wesleycho
force-pushed
the
fix/carousel-indicators
branch
from
4737c50
to
8e83953
Compare
- Force the carousel indicator to not select the slide if the animation has not completed - Factor out `goNext` function to not redefine on each execution of `select` chore(carousel): move `$currentTransition` check to `select` method Fixes angular-ui#3729 Closes angular-ui#3757
- Force the carousel indicator to not select the slide if the animation has not completed - Factor out `goNext` function to not redefine on each execution of `select` chore(carousel): move `$currentTransition` check to `select` method Fixes angular-ui#3729 Closes angular-ui#3757
goNextfunction to not redefine on each execution ofselectPlunker of fix in action here.
This addresses #3729