This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(alert): adjust check for close attribute #3864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| angular.module('ui.bootstrap.alert', []) | |||
|
|
|||
| .controller('AlertController', ['$scope', '$attrs', function ($scope, $attrs) { | |||
| $scope.closeable = 'close' in $attrs; | |||
| $scope.closeable = $attrs.close; | |||
There was a problem hiding this comment.
!!$attrs.close might be clearer since we intend closeable to be a boolean.
|
Did a review. This looks good, small stylistic issue. This change is needed due to: https://github.com/angular/angular.js/blob/d193c3a25caa0d2c6dd149941c23163dbd062e4d/src/ng/compile.js#L2570-L2574 |
- Adjust check due to change in Angular 1.4 where the presence of attribute gives key value of `undefined`, causing variable to contain incorrect truthiness
wesleycho
force-pushed
the
fix/alert-close
branch
from
525c1ae
to
4b56382
Compare
|
Alright, changed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined, causing variable to contain incorrect truthinessThis fixes #3848 in a way that does not conflict with Angular 1.3.
A Plunker with the 1.4 fix can be seen in action here.
A Plunker with the fix applied to 1.3 can be seen in action here.