Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Improved accessibility of collapse #3920

Closed

Conversation

RicardoRFaria
Copy link
Contributor

  • Added aria attributes to collapse
  • Updated documentation with accessibility example
  • Created tests to new attributes

Referencing the discussion #3526

- Updated documentation with accessibility
@@ -26,6 +29,8 @@ angular.module('ui.bootstrap.collapse', [])
// prevents the animation from jumping to collapsed state
.removeClass('collapse')
.addClass('collapsing');
element.attr('aria-expanded', false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can chain on the other calls to element right after .addClass(...) instead of calling it again

@wesleycho
Copy link
Contributor

Other than those two minor issues, this looks good.

@wesleycho wesleycho added this to the Backlog milestone Jul 17, 2015
@RicardoRFaria
Copy link
Contributor Author

Fixed. Thanks.

@wesleycho wesleycho closed this in 9255134 Jul 17, 2015
@RicardoRFaria RicardoRFaria deleted the collapse_accessibility branch July 20, 2015 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants