This repository has been archived by the owner on May 29, 2019. It is now read-only.
Bugfix that removes "setIsOpen is not a function" #4030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When binding "is-open" to an expression, the variable "getIsOpen" does not have "assign" function after the $parse call. This is ok since the the "isOpen" variable is assigned from the outside anyway. We just need to stop trying to execute the assign function to prevent the error. We might be able to disable more code when the "is-open" attribute is used, but that's a much bigger job.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binding "is-open" to an expression, the variable "getIsOpen" does not have "assign" function after the $parse call. This is ok since the the "isOpen" variable is assigned from the outside anyway. We just need to stop trying to execute the assign function to prevent the error.
We might be able to disable more code when the "is-open" attribute is used, but that's a much bigger job.