Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Remove the angular.version.minor > 4 checks #4122

Closed
1 of 2 tasks
wesleycho opened this issue Aug 6, 2015 · 5 comments
Closed
1 of 2 tasks

Remove the angular.version.minor > 4 checks #4122

wesleycho opened this issue Aug 6, 2015 · 5 comments

Comments

@wesleycho
Copy link
Contributor

These checks should be removed once we hit 0.14.0 & claim angular 1.4+ support.

  • Carousel
  • Modal
@icfantv
Copy link
Contributor

icfantv commented Aug 6, 2015

This is referencing PR #4121 which fixes issue #4119.

@Foxandxss
Copy link
Contributor

Got lost. Don't we have 1.4 support at the moment? I can see changing this line for $injector.has, but I am confused.

@wesleycho
Copy link
Contributor Author

We do, but we still also support 1.3 - there is one check left for the $animate listener, which might be able to be checked by checking

if ($animate.one) {
...
else {
...
}

@wesleycho
Copy link
Contributor Author

Hmm the carousel one is not as easy to remove since the one listener is on the element itself - perhaps I'll hold off on this until 0.14.0.

@wesleycho
Copy link
Contributor Author

Rescheduling this - this is unnecessary at this time, and I don't think it's a good idea to force 1.3 uncompatibility here. Maybe we can revisit for 1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants