This repository has been archived by the owner on May 29, 2019. It is now read-only.
Added ability to handle empty model in timepicker #4203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model can be empty so user must type values into the hour and minute text boxes.
| @@ -255,7 +267,10 @@ angular.module('ui.bootstrap.timepicker', []) | |||
| }; | |||
|
|
|||
| minutesInputEl.bind('blur', function(e) { | |||
| if (!$scope.invalidMinutes && $scope.minutes < 10) { | |||
| ngModelCtrl.$setTouched(); | |||
| if ($scope.minutes === null) { | |||
There was a problem hiding this comment.
Change to if(!$scope.minutes) {
|
I don't think he should change value === null to !value, because that won't work for 0 hours and 0 minutes. |
|
Good point - however, the other aspects are still issues. |
|
Even with code style cleaned up, this PR fails tests. It needs to be worked on before this can be accepted. |
Added ability to handle empty model - fixed PR
Added ability to handle empty model - fixed tests
|
the PR is green now |
|
History needs to be cleaned up - there should not be any merge commits. |
This was referenced Oct 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model can be empty so user must type values into the hour and minute
text boxes. This closes #1114.