Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(modal): Wait for animation before focus. #4300

Closed
wants to merge 1 commit into from
Closed

fix(modal): Wait for animation before focus. #4300

wants to merge 1 commit into from

Conversation

wawyed
Copy link
Contributor

@wawyed wawyed commented Aug 28, 2015

Previously modalWindow directive focused itself or the autofocus element immediately after triggering the modalInClass animation, which could result in undesired behaviour since browsers try to scroll focused elements into view.
Now modelWindow waits until the animation is finished (if an animation was required) before applying focus.

Closes #4274

Previously modalWindow directive focused itself or the autofocus element immediately after triggering the modalInClass animation, which could result in undesired behaviour since browsers try to scroll focused elements into view.
Now modelWindow waits until the animation is finished (if an animation was required) before applying focus.

Closes #4274
@wesleycho wesleycho added this to the 0.13.4 (Performance) milestone Aug 28, 2015
@wesleycho
Copy link
Contributor

LGTM, but holding off until tests are fixed in master before fixing here and merging.

@wesleycho wesleycho closed this in 937a1f3 Aug 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants