Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(collapse): use uib- prefix #4370

Closed
wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Contributor

So this is the proposal for collapse prefixing.

@Foxandxss
Copy link
Contributor Author

@wesleycho I need you to check this out, I know you're in vacation, but if you agree, I can do a couple of this before you come back.

@icfantv you too.

@wesleycho
Copy link
Contributor

LGTM

Controllers need to be prefixed too for the others - this should be a 100% breaking change I think. Thoughts?

@Foxandxss
Copy link
Contributor Author

You're right @wesleycho, we should prefix controllers too. Will update the instructions.

This PR is not a breaking change tho, it still works as it did before. The breaking change will come when we decide to rm all the .old files.

We need somehow (for when we release 0.14 with all prefixes) to announce that we have prefixes now and that the users should update their projects ASAP.

@wesleycho
Copy link
Contributor

Right, my comment was just before you delved down into the other work :) .

As for the notifying users, perhaps we can mention it on the home page and the README - the deprecation notices will serve enough warning to current users I think.

@wesleycho wesleycho added this to the 0.14.0 (Bootstrap 3.3) milestone Sep 8, 2015
@Foxandxss
Copy link
Contributor Author

@wesleycho Updated. Now we just need to remove from the comment to the bottom to clean the deprecated modules.

@wesleycho
Copy link
Contributor

Alright, this looks better to me - good to go!

@Foxandxss Foxandxss closed this in 9bdb32e Sep 9, 2015
@Foxandxss Foxandxss deleted the collapseprefix branch October 5, 2015 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants