This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): isOpen to work with expressions #4380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scope.$digest(); | ||
| })); | ||
|
|
||
| it( 'should show and hide with the expression', function() { |
| @@ -221,7 +221,7 @@ angular.module('ui.bootstrap.tooltip', ['ui.bootstrap.position']) | |||
|
|
|||
| // And show the tooltip. | |||
| ttScope.isOpen = true; | |||
| if (isOpenExp) { | |||
| if (isOpenExp && angular.isFunction(isOpenExp.assign)) { | |||
There was a problem hiding this comment.
I'm a bit confused - does this not work currently?
There was a problem hiding this comment.
It will throw an exception if using an expression instead of a model value, this change will allow for both implementations.
There was a problem hiding this comment.
I should have commented, I read the related issue and understood.
The is-open attribute should work with expressions as well as model values Closes #4380
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
The is-open attribute should work with expressions as well as model values Closes angular-ui#4380 Fixes angular-ui#4362
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
The is-open attribute should work with expressions as well as model values Closes angular-ui#4380 Fixes angular-ui#4362
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is-open attribute should work with expressions
as well as model values