This repository has been archived by the owner on May 29, 2019. It is now read-only.
Corrected the meridian threshold when determining if toggling should be allowed in the timepicker. #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly compare against 12 (instead of 13) when determining if the resulting time should be compared against the minimum or the maximum. If the selected time was after noon, the resulting time after toggling would be in the morning of the same day, and should be compared against the minimum and not the maximum.
|
I took a harder look at this, and this LGTM. Thanks for this catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the noToggleMeridian method in the timepicker directive to correctly compare against 12 (instead of 13) when determining if the resulting time should be compared against the minimum or the maximum. If the selected time was after noon, the resulting time after toggling would be in the morning of the same day, and should be compared against the minimum and not the maximum.