This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): stop esc keydown event #5787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeg
added a commit
to deeg/bootstrap
that referenced
this pull request
Apr 12, 2016
Fixes angular-ui#5778 Closes angular-ui#5787 BREAKING CHANGE: Stops propagation of keydown event when escape key is pressed. Removes keydown event from the document and moves it to the dropdown element.
|
@wesleycho, not sure if switching the keydown event from document to element will have any ramifications I didn't think about. Escape and keyboard nav still seems to work fine for me in the linked plunker. The reason I did this was because the document event was catching after the modal escape key event had already fired so stopPropagation didn't do anything. Couldn't think of a nicer way to solve this than to move the event over to the element. |
| @@ -26,8 +26,10 @@ describe('uib-dropdown', function() { | |||
|
|
|||
| var triggerKeyDown = function (element, keyCode) { | |||
| var e = $.Event('keydown'); | |||
| spyOn(e, "stopPropagation"); | |||
There was a problem hiding this comment.
Use single quotes - also add .and.callThrough()
|
I think that switch is ok, judging by the code and playing around with the Plunker. I'm ok with this change. |
Fixes angular-ui#5778 Closes angular-ui#5787 BREAKING CHANGE: Stops propagation of keydown event when escape key is pressed. Removes keydown event from the document and moves it to the dropdown element.
|
@wesleycho, sounds good, thanks. I made the requested changes. |
|
LGTM if it passes the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5778
BREAKING CHANGE: Stops propagation of keydown event when escape key is pressed. Removes keydown event from the document and moves it to the dropdown element.
Plunker with fix