Skip to content

Commit

Permalink
fix(grunt): cut-release wasn't running done()
Browse files Browse the repository at this point in the history
  • Loading branch information
c0bra committed Dec 20, 2013
1 parent 129f28b commit 025c61b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ script:
- grunt
# - git config credential.helper "store --file=.git/credentials"
# - echo "https://${GITHUB_NAME}:${GITHUB_PASS}@github.com" > .git/credentials
- grunt test:ci
- grunt release

after_success:
- grunt test:ci
# after_success:

after_script:
- ./travis_print_logs.sh
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ module.exports = function(grunt) {
}
},

cutrelease: {
'cut-release': {
options: {
cleanup: true,
keepUnstable: false
Expand Down Expand Up @@ -348,5 +348,5 @@ module.exports = function(grunt) {
}
});

grunt.registerTask('release', ['clean', 'build', 'cutrelease', 'gh-pages']);
grunt.registerTask('release', ['clean', 'build', 'cut-release', 'gh-pages']);
};
3 changes: 1 addition & 2 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
1. `readableColumnNames` need to be overrideable by i18n.
1. Add banners to compiled .css files (grunt-banner?)
1. Add grunt-nuget task to autodeploy builds to nuget
1. Use: git describe --tags `git rev-list --tags --max-count=1`
to replace the code in utils.getVersion();
1. Try to reomve `npm install` commands from travis before-script

1. [DONE] Add --browsers option for testing on saucelabs with specific browser(s)
1. [DONE] Make karmangular run in `watch` mode and in singlerun too.
Expand Down
4 changes: 3 additions & 1 deletion lib/grunt/plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ module.exports = function(grunt) {
grunt.log.writeln(util.getStableVersion());
});

grunt.registerMultiTask('cutrelease', 'Release the built code', function() {
grunt.registerMultiTask('cut-release', 'Release the built code', function() {
// Require the build and ngdocs tassk to be run first
grunt.task.requires(['build']);

Expand Down Expand Up @@ -232,5 +232,7 @@ module.exports = function(grunt) {
}
});
});

done();
});
};

0 comments on commit 025c61b

Please sign in to comment.