Skip to content

Commit

Permalink
fix(Selection): Remove IE11 ellipsis in header
Browse files Browse the repository at this point in the history
For some reason IE11 turns the   in the selection row header's header
cell into an ellipsis. Adding text-overflow: clip to .ui-grid-contents
fixes this but as a custom headerCellTemplate has to be defined, the
easier thing is just to remove all the unneeded stuff from the header cell
completely.

This change will probably be overwritten if and when we use the header
cell to actually do something.
  • Loading branch information
c0bra committed Oct 8, 2014
1 parent ffa8000 commit a8ac76c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/features/selection/js/selection.js
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,14 @@
pre: function ($scope, $elm, $attrs, uiGridCtrl) {
uiGridSelectionService.initializeGrid(uiGridCtrl.grid);
if (uiGridCtrl.grid.options.enableRowHeaderSelection) {
var cellTemplate = 'ui-grid/selectionRowHeader';
var selectionRowHeaderDef = { name: 'selectionRowHeaderCol', displayName: '', width: 30, cellTemplate: cellTemplate};
var selectionRowHeaderDef = {
name: 'selectionRowHeaderCol',
displayName: '',
width: 30,
cellTemplate: 'ui-grid/selectionRowHeader',
headerCellTemplate: 'ui-grid/selectionHeaderCell'
};

uiGridCtrl.grid.addRowHeaderColumn(selectionRowHeaderDef);
}
},
Expand Down
4 changes: 4 additions & 0 deletions src/features/selection/templates/selectionHeaderCell.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<div>
<div class="ui-grid-vertical-bar">&nbsp;</div>
<div class="ui-grid-cell-contents" col-index="renderIndex"></div>
</div>

0 comments on commit a8ac76c

Please sign in to comment.