Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding and removing columns toggle visible ruins the grid. #2789

Closed
mikila85 opened this issue Feb 17, 2015 · 1 comment
Closed

adding and removing columns toggle visible ruins the grid. #2789

mikila85 opened this issue Feb 17, 2015 · 1 comment
Assignees
Milestone

Comments

@mikila85
Copy link

reproduce:

  1. go here: http://ui-grid.info/docs/#/tutorial/113_adding_and_removing_columns
  2. press 4 times "Add"
  3. press 1 time "Toggle Visible"
  4. scroll down.
@c0bra c0bra added this to the 3.0 milestone Feb 17, 2015
@c0bra c0bra self-assigned this Feb 18, 2015
@c0bra
Copy link
Contributor

c0bra commented Feb 18, 2015

Note to self: the problem is here: https://github.com/angular-ui/ng-grid/blob/fee00cdfa5aeaeb5a10db8ea71e64035eb39bba0/src/js/core/factories/Grid.js#L796

a & b here are GridColumn objects. This probably needs to be a.displayName.match and b.displayName.match.

Although... this works initially with the first few columns. So what happens with column number 4?

@c0bra c0bra closed this as completed in dd6dc15 Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants