Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned cols with virtualization having left margin #2821

Closed
cookednoodles opened this issue Feb 20, 2015 · 2 comments
Closed

Pinned cols with virtualization having left margin #2821

cookednoodles opened this issue Feb 20, 2015 · 2 comments
Assignees
Milestone

Comments

@cookednoodles
Copy link
Contributor

After e7bd6f2

It appears that restyle is adding a left margin on pins cols because the !renderContainer.disableColumnOffset condition is no longer being checked, this is leading to the pinned col disappearing when virtualized.

This is reproducible when scrolling to the far right on http://ui-grid.info/docs/#/tutorial/203_pinning

@c0bra
Copy link
Contributor

c0bra commented Feb 20, 2015

I'm not seeing any bad behavior on that tutorial. The pinned columns stay right where they are.

@cookednoodles
Copy link
Contributor Author

This is interesting, its only seems to be happening when not at full width
screenshot - 02202015 - 10 40 30 pm

@c0bra c0bra closed this as completed in 09f478c Feb 23, 2015
@c0bra c0bra self-assigned this Feb 23, 2015
@c0bra c0bra added this to the 3.0 milestone Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants