-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
displayName of empy string defaults to field property name #363
Comments
I noticed this as well, had to use:
|
ghost
assigned c0bra
Apr 26, 2013
c0bra
added a commit
that referenced
this issue
Apr 29, 2013
When the columnDef displayName property was an empty string, the column class was defaulting to using the field name in the header template. Now it will allow an empty string and will only use the field name if displayName is undefined.
c0bra
added a commit
that referenced
this issue
Apr 30, 2013
When the columnDef displayName property was an empty string, the column class was defaulting to using the field name in the header template. Now it will allow an empty string and will only use the field name if displayName is undefined.
Fixed in 2.0.6 branch. |
ui-grid colDef.name or colDef.field property is required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e.g.
Will show "id" instead of nothing for the column header row. column.js should probably check that displayName is undefined for using the field property, rather than just this || switch:
The text was updated successfully, but these errors were encountered: