-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Persian Translation. #3842
Conversation
salarmehr
commented
Jun 23, 2015
Travis's errors:
These will need to be fixed before we can merge this. |
@JLLeitschuh They are notice indeed. The pointed characters are quit safe. The push can be merged safely. |
The travis build failed however, you will need to figure out a way to get the build to pass before we can merge it in. |
@salarmehr You could try saving the file as UTF-8 and running |
@c0bra Merging all i18n files in the built file make it heavy. Please keep them separate. The developer can merge the needed language himself. |
@salarmehr Sounds like a good suggestion. You can open a separate issue for that if you want. Also your commit includes changes to pagination.html, which you probably didn't intend. Can you fix that, rebase, and push again? Thanks. |
@c0bra I'm not sure how do that. May you please shed some light on it? If possible please manually copy and paste the new fa.js file to your local repo and ignore the PRl. |
@salarmehr I went ahead and brought your changes in manually. Thanks for the commit! |