Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saveState not saving current page size #4146

Closed
tringuyenminh92 opened this issue Aug 9, 2015 · 0 comments
Closed

saveState not saving current page size #4146

tringuyenminh92 opened this issue Aug 9, 2015 · 0 comments
Labels
grid-savestate type: bug

Comments

@tringuyenminh92
Copy link

As i checked, $scope.gridApi.saveState.save() does not save current page size value and restore method doesn't restore previous page size value. So that i think there will be a wrong position scrollbar when:
_Call method to save current state of grid. (current page size in 100 and current position of scrollbar in row 47th)
_Change the page size (change to 20)
_Call method to restore the state
_The scrollbar will be shown in wrong position.
dsjellz pushed a commit to dsjellz/ui-grid that referenced this issue Feb 1, 2016
fix(saveState): Fixes angular-ui#4146 - Allow saving of pagination state
449c000
@dsjellz dsjellz mentioned this issue Feb 1, 2016
Merged
dsjellz pushed a commit to dsjellz/ui-grid that referenced this issue Feb 2, 2016
fix(saveState): Fixes angular-ui#4146 - Allow saving of pagination state
6b500eb
dsjellz pushed a commit to dsjellz/ui-grid that referenced this issue Feb 2, 2016
fix(saveState): Fixes angular-ui#4146 - Allow saving of pagination state
3ec8406
dsjellz pushed a commit to dsjellz/ui-grid that referenced this issue Feb 2, 2016
fix(saveState): Fixes angular-ui#4146 - Allow saving of pagination state
c6d3b2a
JLLeitschuh added a commit that referenced this issue Feb 3, 2016
@JLLeitschuh
Merge pull request #5052 from dsjellz/bugfix/issue-4146
2b6ec4f 
fix(saveState): Fixes #4146 - Allow saving of pagination state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
grid-savestate type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JLLeitschuh @tringuyenminh92