Skip to content

expandable grid does not update scroll bar when a row is expanded #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost opened this issue Jan 5, 2015 · 5 comments
Open

expandable grid does not update scroll bar when a row is expanded #2486

ghost opened this issue Jan 5, 2015 · 5 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jan 5, 2015

When expanding a row to reveal a sub-grid, the scroll bar does not immediately update. It only updates after it is used to scroll up or down. This issue is problematic when expanding the last couple rows in the grid, you must first scroll up to reset the scroll bar, then scroll back down.

How to reproduce:

  1. Go to tutorial for expandable grid: http://ui-grid.info/docs/#/tutorial/306_expandable_grid
  2. Scroll to the bottom of the top grid and expand row 499
  3. Notice that the scroll bar does not adjust, and you must scroll up before being able to scroll down
@PaulL1
Copy link
Contributor

PaulL1 commented Jan 20, 2015

Unfortunately I'm on a Mac, so I can't check this to see if it's been recently fixed (I get no scroll bars). But @kevin-sage, have you seen this? Might be worth checking with your changes.

@PaulL1 PaulL1 added this to the 3.0 milestone Jan 20, 2015
@PaulL1 PaulL1 modified the milestones: 3.1, 3.0 Mar 28, 2015
@YonatanKra
Copy link
Contributor

It's not fixed. Here's an example:
http://plnkr.co/edit/Hept2UgXocjCdbZJYqhi?p=preview
Open the first two rows and scroll. It not only leaves a gap at the bottom - it also jumps at a certain point (you can try scrolling with the scroll buttons step by step to see the jump in action).
I believe the issue is the calculation of vertScrollPercentage (e.g. the new div is bigger due to the expanded row, but you calculate the rows height without including the expanded rows' heights). It's even more comlicated in my fork, since each expandable row has its own rowHeight.

@swalters swalters self-assigned this Jan 29, 2016
@schandra-rpx
Copy link

Anyone has solution for this bug?

@idangozlan
Copy link
Contributor

+1

1 similar comment
@antonbezpalov
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants