Skip to content

Opening expandable grid causes parent grid to collapse when setting width to parent grid columns #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanak opened this issue Feb 13, 2015 · 10 comments

Comments

@tanak
Copy link
Contributor

tanak commented Feb 13, 2015

Opening expandable grid causes parent grid to collapse when setting width to parent grid columns.

collapsing_grid1

collapsing_grid2

I checked this with Chrome, Firefox and IE on Windows.

This is my plunker.
http://plnkr.co/edit/8phKFI0hzfmN7lWK9zMe?p=preview

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 13, 2015

When I used your plunker as-is, it didn't do anything for me, and returned errors in attempting to return the rowTemplate. When I put the rowTemplate inline to avoid this issue, the breakage doesn't occur: http://plnkr.co/edit/DHXXQiQ5tJBNye1l7zQQ?p=preview

Is there a reason you need to retrieve your rowTemplate dynamically?

@PaulL1 PaulL1 added this to the 3.0 milestone Feb 13, 2015
@tanak
Copy link
Contributor Author

tanak commented Feb 14, 2015

Thank you for checking. I also modified the plunker.

I checked on Chrome in Mac again and found that the problem doesn't occur in a small screen.
It seems that the breakage occurs with larger screen.

Could you use a separate window for preview and check again?

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 14, 2015

OK, now I see it. It isn't breaking the formatting so much, rather what's happened is that the grid is wide enough to fit multiple rows onto a single row (the expanded section is much wider than the core grid). If you define the core columns as being wider it doesn't happen (e.g. if you change the widths to 300 each). However, if you don't know how wide the screen is then this won't work. Setting the widths in % might work (if they always add to 100% or thereabouts), but if you let users resize their own columns this could still be a problem.

I presume that means something is messing up the css, as it only does it below the sub-grid, but I can't see what. @jpuri - any ideas?

@PaulL1
Copy link
Contributor

PaulL1 commented Mar 28, 2015

This appears resolved on the plunker - could you confirm?

@PaulL1 PaulL1 modified the milestones: 3.1, 3.0 Mar 28, 2015
@tanak
Copy link
Contributor Author

tanak commented Mar 29, 2015

I checked with v3.0.0-rc.20-6520046, but expandable seems not to be working with this version.

I also checked the tutorial page, and the result was the same.
http://ui-grid.info/docs/#/tutorial/306_expandable_grid

@PaulL1
Copy link
Contributor

PaulL1 commented Mar 29, 2015

Hmm. That seems to have broken overnight. It looks to be fonts, not code - when I check out the code and build and run it, it's fine locally. It will no doubt come right next time someone pushes something.

@PaulL1
Copy link
Contributor

PaulL1 commented Apr 21, 2015

OK, the fonts have been fixed on this for some time, and the plunker no longer exhibits the poor behaviour. Closing, can you re-raise if this issue recurs?

@PaulL1 PaulL1 closed this as completed Apr 21, 2015
@tanak
Copy link
Contributor Author

tanak commented Apr 21, 2015

I was just checking this issue.
This problem still exists, I found that the problem won't occur if there are not so many columns.
So, I added new plunker with many columns.
http://embed.plnkr.co/cchd0s4PFccTmcy1Sn06/preview

Is it better to open new issue?

@PaulL1 PaulL1 reopened this Apr 21, 2015
@PaulL1
Copy link
Contributor

PaulL1 commented Apr 21, 2015

@jpuri - have you seen this?

@jpuri
Copy link
Contributor

jpuri commented Apr 21, 2015

Hi @PaulL1 ,

I checked the issue in the plunkr, it apparently has something to do with the way we handle horizontal scrolling.
I will spend some more time to look into it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants