Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Make simple logger optional #210

Open
r0b- opened this issue Jan 5, 2016 · 3 comments
Open

Make simple logger optional #210

r0b- opened this issue Jan 5, 2016 · 3 comments

Comments

@r0b-
Copy link

r0b- commented Jan 5, 2016

Would it be possible to make the usage of simple logger optional?
I don't see that much benefits compared to $log here and only have to take care about an additional dependency.

In https://github.com/tombatossals/angular-leaflet-directive it's no dependency (anymore)...

@nmccready
Copy link
Contributor

Comparing to angular-leaflet-directive irrelevant. If you can show me an easy way to optionally load modules and angular services then I can possible do this.

The main motive for it is many people don't want to see any logging by the library unless it is an error. The simple logger makes it easy to keep the libraries logging separate from your application.

Also going for the no dependencies argument is null and void here as ui-leaflet is being broken up and thus will require even more dependencies.

#176

@omeid
Copy link

omeid commented Jan 12, 2016

Perhaps you can bring in the simple logger as an internal dependency of ui-leaflet?

@Meekohi
Copy link

Meekohi commented May 30, 2016

Serious suggestion: Why not remove the dependency on a special logging library and just have a verbose: true option you can configure this directive with to get additional output?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants