Infinite loop when doing a state transition from another state

[phindmarsh]

I've just run into an infinite loop when using $state.go() from within a state controller to navigate to another state.

A plunkr showing the problem is here (one using ui-router at 0.2.10 is here)

The second one works as expected, and the first causes the ui-view to render loads of times, eventually exhausting the call-stack. (Open a console to see what I mean).

I spent some time digging into the cause, and it looks like its something to do with the resolveState() function around line 1135 of state.js, but I'm not sure (basically thats as far down as I got)

Any thoughts?

[phindmarsh]

Looks like it was potentially introduced in this commit:

54004a1 (PR #936)

(editing the plunkr to use the SHA from the commit before seems to work fine, and breaks with the one above)

[phindmarsh]

Aaand it looks like it is solved by wrapping the call to $state.go() in a stateChangeSuccess event handler (plunkr)

$scope.$on('$stateChangeSuccess', function () {
    $state.go('statename');
}); 

(source)

[nateabele]

I just checked your version of the Plunkr against 0.2.10. I'm not sure what I should be seeing, but there was no error and the output (from what I could tell by reading the code) appeared to be as expected.

[phindmarsh]

The version using 0.2.10 is the correctly working version. The error I'm referring to is present in the master branch (specifically, commits after 54004a1)

Heres some screenshots of the error as I see it: https://cloudup.com/c7vzH4inkuk (The one with heaps of repeating lines is the broken one.)

[eddiemonge]

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb