-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onEnter is called twice if a parameter is an array with more than one element #1414
Comments
You're seeing this: The params code got a major overhaul in 0.2.11. You were relying on the array being coerced to a String. You can now implement your own typed params, and could create an array type. However, from what I can tell, it looks like query search params can not be typed. Hmmm... @nateabele is this by design? I need to do some more research, stay tuned. https://github.com/angular-ui/ui-router/blob/master/src/urlMatcherFactory.js#L143 |
@christopherthielen Nope. Weird. Btw, I had a quick poke at this. It looks like the whole |
I'll take this, I need to get familiar with the typed params anyway. |
I've got a bunch of Type fixes in a private branch. Here's a working plunk. http://plnkr.co/edit/KQ9PdnouwJskxY4IK7uO?p=preview @nateabele I have about 6 commits to review with you. You can see the cumulative codebase with all the commits at https://github.com/christopherthielen/ui-router/tree/default-type-coersion |
Anything I could do to help move this along? |
@realityking, thanks for the offer . I have a few more things to clean up related to Type(s) before I push this. 0.2.12 should come shortly after that. |
Alright. I'll test this in our app after this is merged (and hopefully before the release). |
@realityking please build from master and test |
Works perfectly. Thank you! |
This seems to be a regression and currently stops us from updating to 0.2.11.
Plunkr: http://plnkr.co/edit/PmwRrdSMnlAetItQBeBl?p=info
The issue only occurs und the following conditions:
If you need any more information I'd be happy to help. I digging trough the callstack for both calls, and they seem to come form completely different places. I'm not familiar enough with the inner workings of UI Router to make any sense out of the behavior I saw.
The text was updated successfully, but these errors were encountered: