New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uiSref): Bind ui-sref to DOM events #3343

Merged

christopherthielen merged 1 commit into angular-ui:master from gcca:master

Feb 25, 2017

Contributor

gcca commented Feb 18, 2017 •

edited

Loading

Using ui-sref-opts="{ event: ['click', 'dblclick'] }" we can override the default binding to ui-sref directive.

Fixes #3169

Contributor

christopherthielen commented Feb 18, 2017

Looks good! Could you please:

also update the ui-state directive https://github.com/angular-ui/ui-router/blob/master/src/directives/stateDirectives.ts#L391-L396
add some docs https://github.com/angular-ui/ui-router/blob/master/src/directives/stateDirectives.ts#L158-L161


feat(uiSref): Bind ui-sref to DOM events

fe63202

christopherthielen merged commit 193ac2e into angular-ui:master

renovate-tests mentioned this pull request

Update dependency angular-ui-router to v1 renovate-tests/discover-package-files#15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment