fix: properly gc on destruction

- Properly garbage collect resize handler when directive is destroyed - Properly debounce callback
angular-ui · Mar 30, 2016 · 95692e7 · 95692e7
1 parent a4a010d
commit 95692e7
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -631,12 +631,14 @@ uis.controller('uiSelectCtrl',
     }
   }
 
+  var onResize = $$uisDebounce(function() {
+    ctrl.sizeSearchInput();
+  }, 50);
+
+  angular.element($window).bind('resize', onResize);
+
   $scope.$on('$destroy', function() {
     ctrl.searchInput.off('keyup keydown tagged blur paste');
+    angular.element($window).off('resize', onResize);
   });
-
-  angular.element($window).bind('resize', $$uisDebounce(function() {
-    ctrl.sizeSearchInput();
-  }), 50);
-
 }]);