Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

ngChange after refreshComponent #1327

Open
oezkany opened this issue Nov 27, 2015 · 4 comments
Open

ngChange after refreshComponent #1327

oezkany opened this issue Nov 27, 2015 · 4 comments

Comments

@oezkany
Copy link

oezkany commented Nov 27, 2015

Hi,

you guys recently checked in a fix that when the model of a multiSelect component has changed, so refreshComponent will be called. Here: #1243

BUT:
It would be very nice if the refreshComponent would call a ngChange method. I.e. as a configurable directive attribute where we cann pass our pointer of method, which concrete method will be called.

Example:

<ui-select on-refesh="myNgChangeMethod">
  ...
</ui-select>
@rcrodrigues
Copy link

+1

@aaronroberson
Copy link
Contributor

@oezkany I've merged in #1243 and it will land in the next release. However, we are not keen on adding a plethora of directive attributes to the project. I would love to see a PR that refactors the the directive away from having a million attributes and instead accepting a config object.

@oezkany
Copy link
Author

oezkany commented Apr 19, 2016

@aaronroberson Thanks. Of course I will test it and will give you a feedback.

@aaronroberson
Copy link
Contributor

By testing, you mean you'll write unit tests?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants