Skip to content

Commit 18e5d2d

Browse files
oocxoocx
committed
feat(@ngtools/webpack): allow .svg files as templates
With directTemplateLoading enabled, components can now use .svg files as templates. For AOT builds, the Angular compiler host now reads .svg files directly when reading component templates. For JIT builds, replaceResources creates a require call that directly uses raw-loader instead of using the loader provided by the current webpack configuration. Closes #10567
2 parents f1e092b + 58bc5b8 commit 18e5d2d

File tree

503 files changed

+8941
-4667
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

503 files changed

+8941
-4667
lines changed

‎.appveyor.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ install:
1111
- ps: Install-Product node $env:nodejs_version
1212
# --network-timeout is a workaround for https://github.com/yarnpkg/yarn/issues/6221
1313
- yarn --frozen-lockfile --network-timeout=500000
14-
- yarn webdriver-update-appveyor
14+
- yarn webdriver-update
1515

1616
test_script:
1717
- node --version

‎.buildkite/pipeline.yml‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
steps:
2+
- label: windows-test
3+
commands:
4+
# Yarn workspaces creates directory junctions inside node_modules, but these fail in docker.
5+
# E.g. inside the container, `mklink /J "C:\src\_" "C:\src\packages\_"` will fail with
6+
# `Access is denied.`
7+
# https://github.com/moby/moby/issues/37024
8+
# As a workaround, we copy all files in the shared volume and run the commands in the new dir.
9+
- xcopy C:\workdir C:\workdir-copy /E /H /K /S /Q /I
10+
- cd C:\workdir-copy
11+
# Actual CI commands
12+
# --network-timeout is a workaround for https://github.com/yarnpkg/yarn/issues/6221
13+
- yarn install --frozen-lockfile --non-interactive --network-timeout 500000
14+
- yarn webdriver-update
15+
- node --version
16+
- yarn --version
17+
- yarn test
18+
# Move this file into the .buildkite folder if Appveyor is removed.
19+
- appveyor-e2e.bat
20+
# - bazel test ...
21+
plugins:
22+
- docker#v2.1.0:
23+
image: "filipesilva/node-bazel-windows:0.0.2"
24+
# Times out in 2h
25+
timeout_in_minutes: 120
26+
# Automatically retries up to 2 times.
27+
retry:
28+
automatic:
29+
exit_status: "*"
30+
limit: 2
31+
agents:
32+
windows: true

‎.circleci/config.yml‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
parallelism: 4
7575
steps:
7676
- attach_workspace: *attach_options
77-
- run: npm run webdriver-update-circleci
77+
- run: npm run webdriver-update
7878
- run: npm run test-large -- --full --nb-shards=${CIRCLE_NODE_TOTAL} --shard=${CIRCLE_NODE_INDEX}
7979

8080
e2e-cli:
@@ -114,6 +114,16 @@ jobs:
114114
- attach_workspace: *attach_options
115115
- run: xvfb-run -a node ./tests/legacy-cli/run_e2e --nb-shards=${CIRCLE_NODE_TOTAL} --shard=${CIRCLE_NODE_INDEX} --ng-snapshots
116116

117+
e2e-cli-ivy-snapshots:
118+
<<: *defaults
119+
environment:
120+
BASH_ENV: ~/.profile
121+
resource_class: xlarge
122+
parallelism: 4
123+
steps:
124+
- attach_workspace: *attach_options
125+
- run: xvfb-run -a node ./tests/legacy-cli/run_e2e --nb-shards=${CIRCLE_NODE_TOTAL} --shard=${CIRCLE_NODE_INDEX} --ng-snapshots --ivy
126+
117127
build:
118128
<<: *defaults
119129
steps:
@@ -200,6 +210,12 @@ workflows:
200210
filters:
201211
branches:
202212
only: master
213+
- e2e-cli-ivy-snapshots:
214+
requires:
215+
- build
216+
filters:
217+
branches:
218+
only: master
203219
- snapshot_publish:
204220
requires:
205221
- test

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 6 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,10 @@
1-
<!--
2-
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
3-
-->
4-
### Bug Report or Feature Request (mark with an `x`)
5-
```
6-
- [ ] bug report -> please search issues before submitting
7-
- [ ] feature request
8-
```
1+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
92

10-
### Command (mark with an `x`)
11-
```
12-
- [ ] new
13-
- [ ] build
14-
- [ ] serve
15-
- [ ] test
16-
- [ ] e2e
17-
- [ ] generate
18-
- [ ] add
19-
- [ ] update
20-
- [ ] lint
21-
- [ ] xi18n
22-
- [ ] run
23-
- [ ] config
24-
- [ ] help
25-
- [ ] version
26-
- [ ] doc
27-
```
3+
Please help us process issues more efficiently by filing an
4+
issue using one of the following templates:
285

29-
### Versions
30-
<!--
31-
Output from: `node --version`, `npm --version` and `ng --version`.
32-
Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra? High Sierra?)
33-
-->
6+
https://github.com/angular/angular-cli/issues/new/choose
347

8+
Thank you!
359

36-
### Repro steps
37-
<!--
38-
Simple steps to reproduce this bug.
39-
Please include: commands run (incl args), packages added, related code changes.
40-
A link to a sample repo would help too.
41-
-->
42-
43-
44-
### The log given by the failure
45-
<!-- Normally this include a stack trace and some more information. -->
46-
47-
48-
### Desired functionality
49-
<!--
50-
What would like to see implemented?
51-
What is the usecase?
52-
-->
53-
54-
55-
### Mention any other details that might be useful
56-
<!-- Please include a link to the repo if this is related to an OSS project. -->
10+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

‎.github/ISSUE_TEMPLATE/1-bug-report.md‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
---
2+
name: "\U0001F41EBug report"
3+
about: Report a bug in Angular CLI
4+
---
5+
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
6+
7+
Oh hi there! 😄
8+
9+
To expedite issue processing please search open and closed issues before submitting a new one.
10+
Existing issues often contain information about workarounds, resolution, or progress updates.
11+
12+
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
13+
14+
15+
# 🐞 Bug report
16+
17+
### Command (mark with an `x`)
18+
<!-- Can you pin-point the command or commands that are effected by this bug? -->
19+
<!-- ✍️edit: -->
20+
```
21+
- [ ] new
22+
- [ ] build
23+
- [ ] serve
24+
- [ ] test
25+
- [ ] e2e
26+
- [ ] generate
27+
- [ ] add
28+
- [ ] update
29+
- [ ] lint
30+
- [ ] xi18n
31+
- [ ] run
32+
- [ ] config
33+
- [ ] help
34+
- [ ] version
35+
- [ ] doc
36+
```
37+
38+
### Is this a regression?
39+
40+
<!-- Did this behavior use to work in the previous version? -->
41+
<!-- ✍️--> Yes, the previous version in which this bug was not present was: ....
42+
43+
44+
### Description
45+
46+
<!-- ✍️--> A clear and concise description of the problem...
47+
48+
49+
## 🔬 Minimal Reproduction
50+
<!--
51+
Simple steps to reproduce this bug.
52+
53+
Please include: commands run (including args), packages added, related code changes.
54+
55+
If reproduction steps are not enough for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
56+
57+
Issues that don't have enough info and can't be reproduced will be closed.
58+
59+
You can read more about issue submission guidelines here: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-submitting-an-issue
60+
-->
61+
62+
## 🔥 Exception or Error
63+
<pre><code>
64+
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
65+
<!-- ✍️-->
66+
67+
</code></pre>
68+
69+
70+
## 🌍 Your Environment
71+
<pre><code>
72+
<!-- run `ng version` and paste output below -->
73+
<!-- ✍️-->
74+
75+
</code></pre>
76+
77+
**Anything else relevant?**
78+
<!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->
79+
80+
<!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->

‎.github/ISSUE_TEMPLATE/2-feature-request.md‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
---
2+
name: "\U0001F680Feature request"
3+
about: Suggest a feature for Angular CLI
4+
5+
---
6+
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
7+
8+
Oh hi there! 😄
9+
10+
To expedite issue processing please search open and closed issues before submitting a new one.
11+
Existing issues often contain information about workarounds, resolution, or progress updates.
12+
13+
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
14+
15+
16+
# 🚀 Feature request
17+
18+
19+
### Command (mark with an `x`)
20+
<!-- Can you pin-point the command or commands that are relevant for this feature request? -->
21+
<!-- ✍️edit: -->
22+
```
23+
- [ ] new
24+
- [ ] build
25+
- [ ] serve
26+
- [ ] test
27+
- [ ] e2e
28+
- [ ] generate
29+
- [ ] add
30+
- [ ] update
31+
- [ ] lint
32+
- [ ] xi18n
33+
- [ ] run
34+
- [ ] config
35+
- [ ] help
36+
- [ ] version
37+
- [ ] doc
38+
```
39+
40+
### Description
41+
<!-- ✍️--> A clear and concise description of the problem or missing capability...
42+
43+
44+
### Describe the solution you'd like
45+
<!-- ✍️--> If you have a solution in mind, please describe it.
46+
47+
48+
### Describe alternatives you've considered
49+
<!-- ✍️--> Have you considered any alternative solutions or workarounds?

‎.github/ISSUE_TEMPLATE/3-docs-bug.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
name: "📚 Docs or angular.io issue report"
3+
about: Report an issue in Angular's documentation or angular.io application
4+
5+
---
6+
7+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
8+
9+
Please file any Docs or angular.io issues at: https://github.com/angular/angular/issues/new/choose
10+
11+
For the time being, we keep Angular AIO issues in a separate repository.
12+
13+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

‎.github/ISSUE_TEMPLATE/4-security-issue-disclosure.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
name: ⚠️Security issue disclosure
3+
about: Report a security issue in Angular Framework, Material, or CLI
4+
5+
---
6+
7+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
8+
9+
Please read https://angular.io/guide/security#report-issues on how to disclose security related issues.
10+
11+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

‎.github/ISSUE_TEMPLATE/5-support-request.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
name: "❓Support request"
3+
about: Questions and requests for support
4+
5+
---
6+
7+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
8+
9+
Please do not file questions or support requests on the GitHub issues tracker.
10+
11+
You can get your questions answered using other communication channels. Please see:
12+
https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#question
13+
14+
Thank you!
15+
16+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

‎.github/ISSUE_TEMPLATE/6-angular-framework.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
name: "⚡Angular Framework"
3+
about: Issues and feature requests for Angular Framework
4+
5+
---
6+
7+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
8+
9+
Please file any Angular Framework issues at: https://github.com/angular/angular/issues/new/choose
10+
11+
For the time being, we keep Angular issues in a separate repository.
12+
13+
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

0 commit comments

Comments
 (0)