Skip to content

Commit 88a3794

Browse files
alan-agius4clydin
authored andcommitted
fix(@angular-devkit/build-angular): show missing karma-coverage error when it's not configured
This fixes an issue where previously `karma-coverage must be installed in order to run code coverage` error was shown incorrectly. Closes: #19359
1 parent 73542ad commit 88a3794

File tree

1 file changed

+4
-5
lines changed
  • packages/angular_devkit/build_angular/src/webpack/plugins

1 file changed

+4
-5
lines changed

packages/angular_devkit/build_angular/src/webpack/plugins/karma.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,13 @@ const init: any = (config: any, emitter: any, customFileHandlers: any) => {
9999
const hasIstanbulReporter = reporters.includes('coverage-istanbul');
100100
if (hasCoveragePlugin && !hasCoverageReporter) {
101101
reporters.push('coverage');
102-
}
103-
else if (hasIstanbulPlugin && !hasIstanbulReporter) {
102+
} else if (hasIstanbulPlugin && !hasIstanbulReporter) {
104103
// coverage-istanbul is deprecated in favor of karma-coverage
105104
reporters.push('coverage-istanbul');
105+
} else if (!hasCoveragePlugin && !hasIstanbulPlugin) {
106+
throw new Error('karma-coverage must be installed in order to run code coverage.');
106107
}
107-
else {
108-
throw new Error('karma-coverage must be installed in order to run code coverage');
109-
}
108+
110109
if (hasIstanbulPlugin) {
111110
logger.warn(`'karma-coverage-istanbul-reporter' usage has been deprecated since version 11.\n` +
112111
`Please install 'karma-coverage' and update 'karma.conf.js.' ` +

0 commit comments

Comments
 (0)