Skip to content

Commit 8f77d67

Browse files
alan-agius4alexeagle
authored andcommitted
fix(@angular-devkit/build-angular): update speed-measure-webpack-plugin to 1.3.1
This fixes the issue of it generating an empty speed-measure-plugin.json. Fixes #12763
1 parent 10fb461 commit 8f77d67

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

packages/angular_devkit/build_angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"semver": "5.6.0",
3939
"source-map-support": "0.5.11",
4040
"source-map-loader": "0.2.4",
41-
"speed-measure-webpack-plugin": "1.3.0",
41+
"speed-measure-webpack-plugin": "1.3.1",
4242
"stats-webpack-plugin": "0.7.0",
4343
"style-loader": "0.23.1",
4444
"stylus": "0.54.5",

packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import { Architect } from '@angular-devkit/architect/src/index2';
9-
import { join, normalize } from '@angular-devkit/core';
9+
import { join, normalize, virtualFs } from '@angular-devkit/core';
1010
import { BrowserBuilderOutput } from '../../src/browser/index2';
1111
import { browserBuild, createArchitect, host } from '../utils';
1212

@@ -26,9 +26,13 @@ describe('Browser Builder profile', () => {
2626
const output = await run.result as BrowserBuilderOutput;
2727

2828
expect(output.success).toBe(true);
29+
30+
const speedMeasureLogPath = normalize('speed-measure-plugin.json');
2931
expect(host.scopedSync().exists(normalize('chrome-profiler-events.json'))).toBe(true);
30-
expect(host.scopedSync().exists(normalize('speed-measure-plugin.json'))).toBe(true);
32+
expect(host.scopedSync().exists(speedMeasureLogPath)).toBe(true);
3133

34+
const content = virtualFs.fileBufferToString(host.scopedSync().read(speedMeasureLogPath));
35+
expect(content).toContain('plugins');
3236
await run.stop();
3337
});
3438
});

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8713,10 +8713,10 @@ spdy@^4.0.0:
87138713
select-hose "^2.0.0"
87148714
spdy-transport "^3.0.0"
87158715

8716-
speed-measure-webpack-plugin@1.3.0:
8717-
version "1.3.0"
8718-
resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.0.tgz#c7ffafef513df3d63d5d546c8fc1986dfc4969aa"
8719-
integrity sha512-b9Yd0TrzceMVYSbuamM1sFsGM1oVfyFTM22gOoyLhymNvBVApuYpkdFOgYkKJpN/KhTpcCYcTGHg7X+FJ33Vvw==
8716+
speed-measure-webpack-plugin@1.3.1:
8717+
version "1.3.1"
8718+
resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.1.tgz#69840a5cdc08b4638697dac7db037f595d7f36a0"
8719+
integrity sha512-qVIkJvbtS9j/UeZumbdfz0vg+QfG/zxonAjzefZrqzkr7xOncLVXkeGbTpzd1gjCBM4PmVNkWlkeTVhgskAGSQ==
87208720
dependencies:
87218721
chalk "^2.0.1"
87228722

0 commit comments

Comments
 (0)