test: update no_typescript_runtime_dep_spec to check javascript files

alan-agius4 · clydin · commit a9258338a12a · 2020-05-11T07:45:58.000-04:00
diff --git a/packages/schematics/angular/no_typescript_runtime_dep_spec.js b/packages/schematics/angular/no_typescript_runtime_dep_spec.js
@@ -21,9 +21,9 @@ describe('@schematics/angular javascript code', () => {
           const file = path.join(subdir, f);
           if (fs.statSync(file).isDirectory()) {
             check(file);
-          } else if (file.endsWith('.ts')) {
+          } else if (file.endsWith('.js')) {
             const content = fs.readFileSync(file, { encoding: 'utf-8' });
-            if (content.indexOf(`from 'typescript'`) >= 0) {
+            if (content.includes(`require("typescript")`) || content.includes(`require('typescript')`)) {
               fail(`${file} has a typescript import`);
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,9 @@ describe('@schematics/angular javascript code', () => {`
`21`	`21`	`const file = path.join(subdir, f);`
`22`	`22`	`if (fs.statSync(file).isDirectory()) {`
`23`	`23`	`check(file);`
`24`		`- } else if (file.endsWith('.ts')) {`
	`24`	`+ } else if (file.endsWith('.js')) {`
`25`	`25`	`const content = fs.readFileSync(file, { encoding: 'utf-8' });`
`26`		- if (content.indexOf(`from 'typescript'`) >= 0) {
	`26`	+ if (content.includes(`require("typescript")`) \|\| content.includes(`require('typescript')`)) {
`27`	`27`	fail(`${file} has a typescript import`);
`28`	`28`	`}`
`29`	`29`	`}`