fix(@ngtools/webpack): add template/styles as dependencies

So they are rebuilt when the resource changes.

This PR refactor _replaceResources into _getResourceNodes which returns
the AST nodes for templateUrl or styleUrls, then use that to get the
URLs (values). For values that are not computable, we simply ignores.

Author: hansl

package.json

@@ -131,6 +131,7 @@
     "conventional-changelog": "^1.1.0",
     "dtsgenerator": "^0.9.1",
     "eslint": "^3.11.0",
+    "eslint-plugin-standard": "^2.1.1",
     "exists-sync": "0.0.4",
     "express": "^4.14.0",
     "jasmine": "^2.4.1",

packages/@ngtools/webpack/src/loader.ts

@@ -274,9 +274,36 @@ function _getResourceRequest(element: ts.Expression, sourceFile: ts.SourceFile)
 function _replaceResources(refactor: TypeScriptFileRefactor): void {
   const sourceFile = refactor.sourceFile;
 
+  _getResourceNodes(refactor)
+    // Get the full text of the initializer.
+    .forEach((node: ts.PropertyAssignment) => {
+      const key = _getContentOfKeyLiteral(sourceFile, node.name);
+
+      if (key == 'templateUrl') {
+        refactor.replaceNode(node,
+          `template: require(${_getResourceRequest(node.initializer, sourceFile)})`);
+      } else if (key == 'styleUrls') {
+        const arr = <ts.ArrayLiteralExpression[]>(
+          refactor.findAstNodes(node, ts.SyntaxKind.ArrayLiteralExpression, false));
+        if (!arr || arr.length == 0 || arr[0].elements.length == 0) {
+          return;
+        }
+
+        const initializer = arr[0].elements.map((element: ts.Expression) => {
+          return _getResourceRequest(element, sourceFile);
+        });
+        refactor.replaceNode(node, `styles: [require(${initializer.join('), require(')})]`);
+      }
+    });
+}
+
+
+function _getResourceNodes(refactor: TypeScriptFileRefactor) {
+  const { sourceFile } = refactor;
+
   // Find all object literals.
-  refactor.findAstNodes(sourceFile, ts.SyntaxKind.ObjectLiteralExpression, true)
-    // Get all their property assignments.
+  return refactor.findAstNodes(sourceFile, ts.SyntaxKind.ObjectLiteralExpression, true)
+  // Get all their property assignments.
     .map(node => refactor.findAstNodes(node, ts.SyntaxKind.PropertyAssignment))
     // Flatten into a single array (from an array of array<property assignments>).
     .reduce((prev, curr) => curr ? prev.concat(curr) : prev, [])
@@ -288,27 +315,38 @@ function _replaceResources(refactor: TypeScriptFileRefactor): void {
         return false;
       }
       return key == 'templateUrl' || key == 'styleUrls';
-    })
-    // Get the full text of the initializer.
-    .forEach((node: ts.PropertyAssignment) => {
-      const key = _getContentOfKeyLiteral(sourceFile, node.name);
+    });
+}
+
+
+function _getResourcesUrls(refactor: TypeScriptFileRefactor): string[] {
+  return _getResourceNodes(refactor)
+    .reduce((acc: string[], node: ts.PropertyAssignment) => {
+      const key = _getContentOfKeyLiteral(refactor.sourceFile, node.name);
 
       if (key == 'templateUrl') {
-        refactor.replaceNode(node,
-          `template: require(${_getResourceRequest(node.initializer, sourceFile)})`);
+        const url = (node.initializer as ts.StringLiteral).text;
+        if (url) {
+          acc.push(url);
+        }
       } else if (key == 'styleUrls') {
         const arr = <ts.ArrayLiteralExpression[]>(
           refactor.findAstNodes(node, ts.SyntaxKind.ArrayLiteralExpression, false));
         if (!arr || arr.length == 0 || arr[0].elements.length == 0) {
           return;
         }
 
-        const initializer = arr[0].elements.map((element: ts.Expression) => {
-          return _getResourceRequest(element, sourceFile);
+        arr[0].elements.forEach((element: ts.Expression) => {
+          if (element.kind == ts.SyntaxKind.StringLiteral) {
+            const url = (element as ts.StringLiteral).text;
+            if (url) {
+              acc.push(url);
+            }
+          }
         });
-        refactor.replaceNode(node, `styles: [require(${initializer.join('), require(')})]`);
       }
-    });
+      return acc;
+    }, []);
 }
 
 
@@ -362,6 +400,12 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }) {
           plugin.diagnose(sourceFileName);
         }
       })
+      .then(() => {
+        // Add resources as dependencies.
+        _getResourcesUrls(refactor).forEach((url: string) => {
+          this.addDependency(path.resolve(path.dirname(sourceFileName), url));
+        });
+      })
       .then(() => {
         // Force a few compiler options to make sure we get the result we want.
         const compilerOptions: ts.CompilerOptions = Object.assign({}, plugin.compilerOptions, {

packages/@ngtools/webpack/src/webpack.ts

@@ -42,6 +42,7 @@ export interface NormalModule {
 export interface LoaderContext {
   _module: NormalModule;
 
+  addDependency(path: string): void;
   async(): LoaderCallback;
   cacheable(): void;