Skip to content

Commit c272172

Browse files
committed
fix(@angular-devkit/build-angular): update esbuild builder complete log
The complete log has been updated to match the RegExp in https://github.com/angular/angular-cli/blob/c045c99667cec8a5986302d59eef3d326e3a53d2/packages/schematics/angular/workspace/files/__dot__vscode/tasks.json.template#L18 as otherwise vscode debugged will not work correctly when using vscode launcher to launch the dev-server. (cherry picked from commit b2a4f35)
1 parent b21a0e7 commit c272172

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ async function execute(
267267
logBuildStats(context, metafile, initialFiles);
268268

269269
const buildTime = Number(process.hrtime.bigint() - startTime) / 10 ** 9;
270-
context.logger.info(`Complete. [${buildTime.toFixed(3)} seconds]`);
270+
context.logger.info(`Application bundle generation complete. [${buildTime.toFixed(3)} seconds]`);
271271

272272
return executionResult;
273273
}

tests/legacy-cli/e2e/tests/basic/rebuild.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { getGlobalVariable } from '../../utils/env';
66

77
export default async function () {
88
const esbuild = getGlobalVariable('argv')['esbuild'];
9-
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
9+
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
1010
const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/;
1111

1212
const port = await ngServe();

tests/legacy-cli/e2e/utils/project.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export async function ngServe(...args: string[]) {
2727
const port = await findFreePort();
2828

2929
const esbuild = getGlobalVariable('argv')['esbuild'];
30-
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
30+
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
3131

3232
await execAndWaitForOutputToMatch(
3333
'ng',

0 commit comments

Comments
 (0)